Bug 62280

Summary: [Qt] Build fix for building QtWebKit inside of Qt.
Product: WebKit Reporter: Yael <yael>
Component: WebKit QtAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: abecsi, ademar, kling, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch.
none
Patch. none

Yael
Reported 2011-06-08 07:07:57 PDT
When building QtWebKit inside of Qt, -lwebcore and -lwebkit2 are wrongly added to QtWebKit.prl, but they should not.
Attachments
Patch. (2.16 KB, patch)
2011-06-08 07:15 PDT, Yael 		no flags
DetailsFormatted DiffDiff
Patch. (3.56 KB, patch)
2011-06-08 07:26 PDT, Yael 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Yael
Comment 1 2011-06-08 07:15:01 PDT
Created attachment 96418 [details] Patch.
Andras Becsi
Comment 2 2011-06-08 07:26:53 PDT
Comment on attachment 96418 [details] Patch. I would also add the CONFIG -= staticlib line to JSC.pri for consistency reasons. The cause why the build works without it is the order of prepend calls in the QtWebKit.pro file: !v8:prependJavaScriptCoreLib(../../JavaScriptCore) prependWebCoreLib(../../WebCore) webkit2:prependWebKit2Lib(../../WebKit2) Theoretically only the last would have to remove the staticlib, but if we for some reason change the order or use these functions elsewhere then the build might fail again, so it's safer to be consistent.
Yael
Comment 3 2011-06-08 07:26:58 PDT
Created attachment 96419 [details] Patch. Added the same to JavaScriptCore.pri based on bbandix comment on IRC.
Andras Becsi
Comment 4 2011-06-08 07:29:23 PDT
Comment on attachment 96419 [details] Patch. LGTM. Thanks for fixing this.
Andreas Kling
Comment 5 2011-06-08 07:32:14 PDT
Comment on attachment 96419 [details] Patch. rs=me
WebKit Review Bot
Comment 6 2011-06-08 08:28:39 PDT
Comment on attachment 96419 [details] Patch. Clearing flags on attachment: 96419 Committed r88350: <http://trac.webkit.org/changeset/88350>
WebKit Review Bot
Comment 7 2011-06-08 08:28:44 PDT
All reviewed patches have been landed. Closing bug.
Ademar Reis
Comment 8 2011-06-08 08:54:15 PDT
Revision r88350 cherry-picked into qtwebkit-2.2 with commit 55ed382 <http://gitorious.org/webkit/qtwebkit/commit/55ed382>
Note You need to log in before you can comment on or make changes to this bug.