Summary: | Clicking indeterminate checkbox should flip checkedness state | ||||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Keishi Hattori <keishi> | ||||||||||||||
Component: | Forms | Assignee: | Keishi Hattori <keishi> | ||||||||||||||
Status: | RESOLVED FIXED | ||||||||||||||||
Severity: | Normal | CC: | tkent, webkit.review.bot | ||||||||||||||
Priority: | P2 | ||||||||||||||||
Version: | 528+ (Nightly build) | ||||||||||||||||
Hardware: | Unspecified | ||||||||||||||||
OS: | Unspecified | ||||||||||||||||
Attachments: |
|
Description
Keishi Hattori
2011-06-07 21:29:49 PDT
Created attachment 96373 [details]
patch
Comment on attachment 96373 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=96373&action=review > LayoutTests/fast/forms/checkbox-click-indeterminate.html:17 > +// Test if clicking on indeterminate checkbox flips both checked/indeterminate states You had better print this with debug('') for test result readability. > LayoutTests/fast/forms/checkbox-click-indeterminate.html:24 > +// Test if clicking on indeterminate checkbox flips both checked/indeterminate states ditto. > LayoutTests/fast/forms/checkbox-click-indeterminate.html:30 > +// Test if preventDefault restores the checked/indeterminate states ditto. > LayoutTests/fast/forms/checkbox-click-indeterminate.html:36 > + shouldBeTrue('cb.checked'); > + shouldBeFalse('cb.indeterminate'); Are they compatible with other browsers? Created attachment 96377 [details]
fixed patch
> > LayoutTests/fast/forms/checkbox-click-indeterminate.html:36
> > + shouldBeTrue('cb.checked');
> > + shouldBeFalse('cb.indeterminate');
>
> Are they compatible with other browsers?
I modified the test so that it passes in Firefox 4. (I had to add the input element to the DOM tree)
Opera doesn't implement indeterminate checkbox.
Comment on attachment 96377 [details]
fixed patch
ok
Comment on attachment 96377 [details] fixed patch Attachment 96377 [details] did not pass mac-ews (mac): Output: http://queues.webkit.org/results/8812328 New failing tests: fast/forms/checkbox-click-indeterminate.html Created attachment 96423 [details]
Archive of layout-test-results from cr-jail-8
The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: cr-jail-8 Port: Mac Platform: Mac OS X 10.6.7
Comment on attachment 96377 [details]
fixed patch
Clearing review flags so we can investigate why the test did not pass on the Mac.
Created attachment 97737 [details]
updated test results
I needed to update my test expectation file. Comment on attachment 97737 [details] updated test results Rejecting attachment 97737 [details] from commit-queue. Failed to run "['./Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=ec2-cq-01', '--port..." exit_code: 2 Last 500 characters of output: => Tests that will only be fixed if they crash (WONTFIX) (8116): 1 test timed out ( 0.0%) 109 text diff mismatch ( 1.3%) 7957 skipped (98.0%) Unexpected flakiness: text diff mismatch (1) inspector/styles/parse-utf8-bom.html = TEXT PASS Unexpected flakiness: tests timed out (1) perf/array-binary-search.html = TEXT TIMEOUT PASS Regressions: Unexpected no expected results found : (1) fast/forms/checkbox-click-indeterminate.html = MISSING Full output: http://queues.webkit.org/results/8911368 Created attachment 97741 [details]
Archive of layout-test-results from ec2-cq-01
The attached test failures were seen while running run-webkit-tests on the commit-queue.
Bot: ec2-cq-01 Port: Chromium Platform: Linux-2.6.35-28-virtual-x86_64-with-Ubuntu-10.10-maverick
Created attachment 97742 [details]
didn't realize new-run-webkit-test doesn't generate results
The commit-queue encountered the following flaky tests while processing attachment 97742 [details]: http/tests/local/formdata/send-form-data-constructed-from-form.html bug 62431 (author: jianli@chromium.org) The commit-queue is continuing to process your patch. Comment on attachment 97742 [details] didn't realize new-run-webkit-test doesn't generate results Clearing flags on attachment: 97742 Committed r89229: <http://trac.webkit.org/changeset/89229> All reviewed patches have been landed. Closing bug. |