Bug 62252

Summary: [GTK] Use WebCore scrollbars for the DRT instead of GtkScrolledWindow
Product: WebKit Reporter: Martin Robinson <mrobinson>
Component: WebKitGTKAssignee: Martin Robinson <mrobinson>
Status: RESOLVED FIXED    
Severity: Normal CC: gustavo, xan.lopez
Priority: P3 Keywords: Gtk
Version: 528+ (Nightly build)   
Hardware: PC   
OS: Linux   
Attachments:
Description Flags
Patch gustavo: review+

Martin Robinson
Reported 2011-06-07 17:35:25 PDT
The DRT currently wraps the WebKitWebView in a GtkScrolledWindow, which causes a good deal of flakiness during testing. GtkScrolledWindow operates asynchronously, while many tests are written with the assumption that scrolling is synchronous. By using WebCore-only scrollbars on the bots we can avoid these spurious failures.
Attachments
Patch (747.81 KB, patch)
2011-06-07 17:52 PDT, Martin Robinson 		gustavo: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Martin Robinson
Comment 1 2011-06-07 17:35:52 PDT
I should also mention that this will allow us to share more results between WebKit1 and WebKit2.
Martin Robinson
Comment 2 2011-06-07 17:52:44 PDT
Created attachment 96345 [details] Patch
Gustavo Noronha (kov)
Comment 3 2011-07-07 17:24:10 PDT
Comment on attachment 96345 [details] Patch Looks correct to me.
Gustavo Noronha (kov)
Comment 4 2011-07-07 17:24:46 PDT
Comment on attachment 96345 [details] Patch Looks correct to me.
Martin Robinson
Comment 5 2011-07-25 14:43:57 PDT
Committed r91707: <http://trac.webkit.org/changeset/91707>
Note You need to log in before you can comment on or make changes to this bug.