Bug 62245

Summary: Make the complex text input state a tri-state enum instead of a boolean
Product: WebKit Reporter: Anders Carlsson <andersca>
Component: WebKit2Assignee: Anders Carlsson <andersca>
Status: RESOLVED FIXED    
Severity: Normal CC: andersca, darin, sam, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch sam: review+

Anders Carlsson
Reported 2011-06-07 15:44:29 PDT
Make the complex text input state a tri-state enum instead of a boolean
Attachments
Patch (27.00 KB, patch)
2011-06-07 15:46 PDT, Anders Carlsson 		no flags
DetailsFormatted DiffDiff
Patch (27.60 KB, patch)
2011-08-19 15:44 PDT, Anders Carlsson 		sam: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Anders Carlsson
Comment 1 2011-06-07 15:46:45 PDT
Created attachment 96318 [details] Patch
Darin Adler
Comment 2 2011-06-18 11:31:49 PDT
This patch was never landed. Is it still needed?
Anders Carlsson
Comment 3 2011-06-18 12:08:51 PDT
(In reply to comment #2) > This patch was never landed. Is it still needed? Yes.
Darin Adler
Comment 4 2011-06-18 12:09:35 PDT
Comment on attachment 96318 [details] Patch Lets try the commit queue, then.
WebKit Review Bot
Comment 5 2011-06-18 12:54:00 PDT
Comment on attachment 96318 [details] Patch Rejecting attachment 96318 [details] from commit-queue. Failed to run "['./Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=ec2-cq-01', '--port..." exit_code: 2 Last 500 characters of output: gins/PluginView.h patching file Source/WebKit2/WebProcess/Plugins/Netscape/NetscapePlugin.cpp Hunk #1 succeeded at 75 (offset 1 line). patching file Source/WebKit2/WebProcess/Plugins/Netscape/NetscapePlugin.h patching file Source/WebKit2/WebProcess/Plugins/Netscape/mac/NetscapePluginMac.mm patching file Source/WebKit2/WebProcess/Plugins/Netscape/mac/PluginProxyMac.mm Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--reviewer', u'Sam Weinig', u'--force']" exit_code: 1 Full output: http://queues.webkit.org/results/8881935
Anders Carlsson
Comment 6 2011-08-19 15:44:41 PDT
Created attachment 104583 [details] Patch
Anders Carlsson
Comment 7 2011-08-19 15:50:52 PDT
Committed r93447: <http://trac.webkit.org/changeset/93447>
Note You need to log in before you can comment on or make changes to this bug.