| Summary: | Make the complex text input state a tri-state enum instead of a boolean | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Anders Carlsson <andersca> | ||||||
| Component: | WebKit2 | Assignee: | Anders Carlsson <andersca> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | andersca, darin, sam, webkit.review.bot | ||||||
| Priority: | P2 | ||||||||
| Version: | 528+ (Nightly build) | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Attachments: |
|
||||||||
|
Description
Anders Carlsson
2011-06-07 15:44:29 PDT
Created attachment 96318 [details]
Patch
This patch was never landed. Is it still needed? (In reply to comment #2) > This patch was never landed. Is it still needed? Yes. Comment on attachment 96318 [details]
Patch
Lets try the commit queue, then.
Comment on attachment 96318 [details] Patch Rejecting attachment 96318 [details] from commit-queue. Failed to run "['./Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=ec2-cq-01', '--port..." exit_code: 2 Last 500 characters of output: gins/PluginView.h patching file Source/WebKit2/WebProcess/Plugins/Netscape/NetscapePlugin.cpp Hunk #1 succeeded at 75 (offset 1 line). patching file Source/WebKit2/WebProcess/Plugins/Netscape/NetscapePlugin.h patching file Source/WebKit2/WebProcess/Plugins/Netscape/mac/NetscapePluginMac.mm patching file Source/WebKit2/WebProcess/Plugins/Netscape/mac/PluginProxyMac.mm Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--reviewer', u'Sam Weinig', u'--force']" exit_code: 1 Full output: http://queues.webkit.org/results/8881935 Created attachment 104583 [details]
Patch
Committed r93447: <http://trac.webkit.org/changeset/93447> |