Bug 62240

Summary: DFG JIT - add support for for-loop array initialization
Product: WebKit Reporter: Gavin Barraclough <barraclough>
Component: JavaScriptCoreAssignee: Gavin Barraclough <barraclough>
Status: RESOLVED FIXED    
Severity: Normal CC: webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
The patch sam: review+

Gavin Barraclough
Reported 2011-06-07 15:28:44 PDT
Support put by val beyond vector length.
Attachments
The patch (15.18 KB, patch)
2011-06-07 15:31 PDT, Gavin Barraclough 		sam: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Gavin Barraclough
Comment 1 2011-06-07 15:31:29 PDT
Created attachment 96314 [details] The patch
WebKit Review Bot
Comment 2 2011-06-07 15:35:01 PDT
Attachment 96314 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/ChangeLog', u'Source..." exit_code: 1 Source/JavaScriptCore/dfg/DFGOperations.h:57: The parameter name "array" adds no information, so it should be removed. [readability/parameter_name] [5] Source/JavaScriptCore/dfg/DFGJITCodeGenerator.h:424: Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side. [whitespace/operators] [4] Source/JavaScriptCore/dfg/DFGJITCodeGenerator.h:425: Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side. [whitespace/operators] [4] Total errors found: 3 in 5 files If any of these errors are false positives, please file a bug against check-webkit-style.
Sam Weinig
Comment 3 2011-06-07 15:41:54 PDT
Comment on attachment 96314 [details] The patch View in context: https://bugs.webkit.org/attachment.cgi?id=96314&action=review > Source/JavaScriptCore/dfg/DFGOperations.cpp:202 > + // We should only get here if index is outside the existing vector! The ! is really helping no one.
Gavin Barraclough
Comment 4 2011-06-07 16:03:45 PDT
Fixed in r88280
Note You need to log in before you can comment on or make changes to this bug.