Bug 62224

Summary: [Qt] Pass prototype-inheritance-2.html LayoutTest
Product: WebKit Reporter: Laszlo Gombos <laszlo.gombos>
Component: PlatformAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: ossy, rniwa, webkit.review.bot
Priority: P2 Keywords: LayoutTestFailure, Qt, QtTriaged
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
proposed patch
none
second try
none
3rd try none

Description Laszlo Gombos 2011-06-07 11:58:47 PDT
It seems that it needs the correct expected results for QtWebkit.
Comment 1 Laszlo Gombos 2011-06-07 12:01:08 PDT
Created attachment 96275 [details]
proposed patch
Comment 2 Laszlo Gombos 2011-06-07 12:05:46 PDT
Comment on attachment 96275 [details]
proposed patch

Clearing the review, only meant to change the expected file for Qt.
Comment 3 Laszlo Gombos 2011-06-07 12:45:13 PDT
Created attachment 96284 [details]
second try
Comment 4 Laszlo Gombos 2011-06-07 12:48:27 PDT
Created attachment 96285 [details]
3rd try
Comment 5 Eric Seidel (no email) 2011-06-13 21:19:48 PDT
Comment on attachment 96285 [details]
3rd try

OK.  rs=me.  Why do we need different results for Qt?
Comment 6 WebKit Review Bot 2011-06-13 22:03:10 PDT
Comment on attachment 96285 [details]
3rd try

Clearing flags on attachment: 96285

Committed r88771: <http://trac.webkit.org/changeset/88771>
Comment 7 WebKit Review Bot 2011-06-13 22:03:14 PDT
All reviewed patches have been landed.  Closing bug.
Comment 8 Ryosuke Niwa 2011-06-14 18:38:09 PDT
fast/dom/prototype-inheritance-2.html is failing on Qt:
http://build.webkit.org/results/Qt%20Linux%20Release/r88887%20(34135)/fast/dom/prototype-inheritance-2-pretty-diff.html
Comment 9 Csaba Osztrogonác 2011-06-15 08:24:47 PDT
(In reply to comment #8)
> fast/dom/prototype-inheritance-2.html is failing on Qt:
> http://build.webkit.org/results/Qt%20Linux%20Release/r88887%20(34135)/fast/dom/prototype-inheritance-2-pretty-diff.html

:((((

I updated the wrong expected file: http://trac.webkit.org/changeset/88909