Bug 62196 – Allow drawing a slider thumb for any nodes

• Component: Layout and Rendering
• Status: RESOLVED FIXED

[Kent Tamura]

We currently support only drawing slider thumbs which are children of RenderSlider.
Support grandchild thumbs too.

[Kent Tamura]

Created attachment 96221 [details]
Patch

[Dimitri Glazkov (Google)]

Comment on attachment 96221 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=96221&action=review

I am not thrilled about adding shadow DOM-related functions to RenderObject. It seems like an abstraction leak. But I know you're fixing an abstraction leak, so perhaps this will work out on the long term.

> Source/WebCore/rendering/RenderObject.cpp:248
> +RenderObject* RenderObject::hostRenderer() const

This should probably have a more descriptive name, like shadowNodeHostRenderer().

[Kent Tamura]

(In reply to comment #2)
> I am not thrilled about adding shadow DOM-related functions to RenderObject. It seems like an abstraction leak. But I know you're fixing an abstraction leak, so perhaps this will work out on the long term.

ok, I changed the strategy.
Renderers should retrieve required information via corresponding nodes, and we should avoid assuming a specific tree structure like o->parent()->isSlider().

[Kent Tamura]

Created attachment 96371 [details]
Patch 2

[Dimitri Glazkov (Google)]

Comment on attachment 96371 [details]
Patch 2

View in context: https://bugs.webkit.org/attachment.cgi?id=96371&action=review

This looks pretty cool.

> Source/WebCore/dom/Node.cpp:966
> +Node* Node::focusCheckDelegationNode()

I think this name is a bit confusing. How about "focusDelegate"?

Also, how does this correlate with the work that Ito-san is doing on focus in shadow DOM?

> Source/WebCore/html/shadow/SliderThumbElement.h:-52
> -    bool inDragMode() const { return m_inDragMode; }

Whoo, this is cool!

[Kent Tamura]

Comment on attachment 96371 [details]
Patch 2

View in context: https://bugs.webkit.org/attachment.cgi?id=96371&action=review

>> Source/WebCore/dom/Node.cpp:966
>> +Node* Node::focusCheckDelegationNode()
> 
> I think this name is a bit confusing. How about "focusDelegate"?
> 
> Also, how does this correlate with the work that Ito-san is doing on focus in shadow DOM?

I also thought it was not a good name.  focusDelegate sounds good.

I think this is not related to the Hayato's work.  This is used only for focus rendering delegation. A slider thumb node doesn't have focus conceptually, but it should be rendered with the focus state of the owner <input>.

[Kent Tamura]

Landed: http://trac.webkit.org/changeset/88415