Bug 62186

Summary: [chromium] Make VideoFrameChromium's destructor virtual
Product: WebKit Reporter: Nico Weber <thakis>
Component: New BugsAssignee: Nico Weber <thakis>
Status: RESOLVED FIXED    
Severity: Normal CC: webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Nico Weber
Reported 2011-06-06 22:17:37 PDT
[chromium] Make VideoFrameChromium's destructor virtual
Attachments
Patch (2.29 KB, patch)
2011-06-06 22:20 PDT, Nico Weber 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Nico Weber
Comment 1 2011-06-06 22:20:33 PDT
Created attachment 96202 [details] Patch
Nico Weber
Comment 2 2011-06-06 22:22:29 PDT
I missed this because it's virtually identical to bug 61742. Very similar code in WebMediaPlayerClientImpl::putCurrentFrame (in WebKit/chromium/src/WebMediaPlayerClientImpl) and WebMediaPlayerImpl::putCurrentFrame (in webkit/glue/webmediaplayer_impl.cc) :-/
WebKit Review Bot
Comment 3 2011-06-06 23:11:19 PDT
Comment on attachment 96202 [details] Patch Clearing flags on attachment: 96202 Committed r88220: <http://trac.webkit.org/changeset/88220>
WebKit Review Bot
Comment 4 2011-06-06 23:11:23 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.