Summary: | Change RenderBlock::hitTestColumns to IntPoint | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Emil A Eklund <eae> | ||||||
Component: | Layout and Rendering | Assignee: | Emil A Eklund <eae> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | eric, leviw, simon.fraser, webkit.review.bot | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Bug Depends on: | |||||||||
Bug Blocks: | 60318 | ||||||||
Attachments: |
|
Description
Emil A Eklund
2011-06-06 18:01:54 PDT
Created attachment 96167 [details]
Patch
This will make more sense when 62170 is in. I plan to rename accumulatedOffset before committing, assuming we agree on a name name before then. Comment on attachment 96167 [details]
Patch
OK.
Comment on attachment 96167 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=96167&action=review > Source/WebCore/rendering/RenderBlock.cpp:4025 > + return hitTestContents(request, result, pointInContainer, adjustedPosition.x(), adjustedPosition.y(), hitTestAction) || (hitTestAction == HitTestFloat && hitTestFloats(request, result, pointInContainer, adjustedPosition.x(), adjustedPosition.y())); adjusted position is also a meaningless name IMO. Created attachment 96300 [details]
Patch for landing
Renamed adjustedPosition to finalLocation to mirror the name used previously. Comment on attachment 96300 [details] Patch for landing Rejecting attachment 96300 [details] from commit-queue. Failed to run "['./Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=ec2-cq-01', '--port..." exit_code: 2 Last 500 characters of output: rce/WebCore/ChangeLog Hunk #1 succeeded at 1 with fuzz 3. patching file Source/WebCore/rendering/RenderBlock.cpp Hunk #3 FAILED at 4010. 1 out of 3 hunks FAILED -- saving rejects to file Source/WebCore/rendering/RenderBlock.cpp.rej patching file Source/WebCore/rendering/RenderBlock.h Hunk #1 FAILED at 588. 1 out of 1 hunk FAILED -- saving rejects to file Source/WebCore/rendering/RenderBlock.h.rej Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--force']" exit_code: 1 Full output: http://queues.webkit.org/results/8812100 |