Bug 62135

Summary: Synchronize features.gypi and features_override.gypi in preparation for removing features_override.gypi
Product: WebKit Reporter: Adam Barth <abarth>
Component: New BugsAssignee: Adam Barth <abarth>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, dglazkov, jamesr, leandrogracia, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 62234    
Bug Blocks:    
Attachments:
Description Flags
Patch
none
Patch none

Adam Barth
Reported 2011-06-06 11:37:25 PDT
Synchronize features.gypi and features_override.gypi in preparation for removing features_override.gypi
Attachments
Patch (6.61 KB, patch)
2011-06-06 11:41 PDT, Adam Barth 		no flags
DetailsFormatted DiffDiff
Patch (6.61 KB, patch)
2011-06-06 22:44 PDT, Adam Barth 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Adam Barth
Comment 1 2011-06-06 11:41:16 PDT
Created attachment 96102 [details] Patch
WebKit Review Bot
Comment 2 2011-06-06 11:55:24 PDT
Comment on attachment 96102 [details] Patch Attachment 96102 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/8772433
James Robinson
Comment 3 2011-06-06 12:05:14 PDT
Comment on attachment 96102 [details] Patch Doesn't seem to compile :(
Adam Barth
Comment 4 2011-06-06 12:10:58 PDT
Comment on attachment 96102 [details] Patch Details. Will try again.
Adam Barth
Comment 5 2011-06-06 22:44:06 PDT
Created attachment 96208 [details] Patch
Dimitri Glazkov (Google)
Comment 6 2011-06-07 10:30:47 PDT
Comment on attachment 96208 [details] Patch thrice-nesting is ... must go deeper!
WebKit Commit Bot
Comment 7 2011-06-07 12:18:36 PDT
Comment on attachment 96208 [details] Patch Clearing flags on attachment: 96208 Committed r88254: <http://trac.webkit.org/changeset/88254>
WebKit Commit Bot
Comment 8 2011-06-07 12:18:41 PDT
All reviewed patches have been landed. Closing bug.
Tony Chang
Comment 9 2011-06-07 12:36:28 PDT
Comment on attachment 96208 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=96208&action=review > Source/WebKit/chromium/features.gypi:153 > + ['OS=="mac" or OS=="linux" or (OS=="win" and branding=="Chrome")', { branding appears to be undefined, causing chromium win to not compile. http://build.webkit.org/builders/Chromium%20Win%20Release/builds/26108/steps/gclient/logs/stdio
Note You need to log in before you can comment on or make changes to this bug.