| Summary: | Convert RenderBox::clipRect to IntPoint | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Emil A Eklund <eae> | ||||||||
| Component: | Layout and Rendering | Assignee: | Emil A Eklund <eae> | ||||||||
| Status: | RESOLVED FIXED | ||||||||||
| Severity: | Normal | CC: | ap, commit-queue, eric, leviw, simon.fraser, webkit.review.bot | ||||||||
| Priority: | P2 | ||||||||||
| Version: | 528+ (Nightly build) | ||||||||||
| Hardware: | Unspecified | ||||||||||
| OS: | Unspecified | ||||||||||
| Bug Depends on: | |||||||||||
| Bug Blocks: | 60318 | ||||||||||
| Attachments: |
|
||||||||||
|
Description
Emil A Eklund
2011-06-03 13:15:53 PDT
Created attachment 95957 [details]
Patch
Comment on attachment 95957 [details]
Patch
OK.
Comment on attachment 95957 [details] Patch Rejecting attachment 95957 [details] from commit-queue. Failed to run "['./Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=cr-jail-8', 'apply-..." exit_code: 2 Last 500 characters of output: dering/RenderBox.h patching file Source/WebCore/rendering/RenderLayer.cpp Hunk #1 FAILED at 3394. Hunk #2 FAILED at 3456. Hunk #3 succeeded at 3512 (offset -15 lines). 2 out of 3 hunks FAILED -- saving rejects to file Source/WebCore/rendering/RenderLayer.cpp.rej patching file Source/WebCore/rendering/RenderLayerBacking.cpp Hunk #1 succeeded at 319 (offset -1 lines). Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--reviewer', u'Eric Seidel', u'--force']" exit_code: 1 Full output: http://queues.webkit.org/results/8757885 Created attachment 95979 [details]
Patch for landing
Comment on attachment 95979 [details] Patch for landing Rejecting attachment 95979 [details] from commit-queue. Failed to run "['./Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=ec2-cq-01', '--port..." exit_code: 2 Last 500 characters of output: ). patching file Source/WebCore/rendering/RenderBox.h Hunk #1 FAILED at 346. 1 out of 1 hunk FAILED -- saving rejects to file Source/WebCore/rendering/RenderBox.h.rej patching file Source/WebCore/rendering/RenderLayer.cpp Hunk #2 succeeded at 3441 with fuzz 1. Hunk #3 succeeded at 3512 with fuzz 2. patching file Source/WebCore/rendering/RenderLayerBacking.cpp Hunk #1 succeeded at 319 with fuzz 1. Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--force']" exit_code: 1 Full output: http://queues.webkit.org/results/8760731 Created attachment 96100 [details]
Patch for landing
Comment on attachment 96100 [details] Patch for landing Clearing flags on attachment: 96100 Committed r88183: <http://trac.webkit.org/changeset/88183> All reviewed patches have been landed. Closing bug. The commit-queue encountered the following flaky tests while processing attachment 96100 [details]: http/tests/websocket/tests/frame-length-longer-than-buffer.html bug 61837 (author: abarth@webkit.org) The commit-queue is continuing to process your patch. |