Bug 61996 – [EFL] Paragraph selection API

• Component: WebKit EFL
• Status: RESOLVED WONTFIX

[Grzegorz Czajkowski]

API allows to:
 - get size and position of paragraph for the given point,
 - check if two points are located in the same paragraph.

It doesn't draw anything on WebKit's context just returns needed information to point out a client application html block.

I am wondering whether it's a good place for function ewk_frame_paragraph_rect_get. Maybe this functionality should be moved somewhere in WebCore (like functions enclosingBlock() or inSameParagraph).

[Grzegorz Czajkowski]

Created attachment 95865 [details]
patch

[Leandro Pereira]

Comment on attachment 95865 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=95865&action=review

What would be a plausible use case for these features?

> Source/WebKit/efl/ewk/ewk_frame.cpp:1641
> +Eina_Bool ewk_frame_points_contained_same_paragraph_check(Evas_Object* o, int x1, int y1, int x2, int y2)

How about calling this ewk_frame_points_in_same_paragraph_get()?

[Grzegorz Czajkowski]

(In reply to comment #2)
> (From update of attachment 95865 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=95865&action=review
> 
> What would be a plausible use case for these features?

One of a possible scenario:
1. User starts to select text using WebKit's selection.
2. If user reaches end of current paragraph then whole paragraph is selected as rectangle.
3. UI application shows handles to control paragraph's selection.

> 
> > Source/WebKit/efl/ewk/ewk_frame.cpp:1641
> > +Eina_Bool ewk_frame_points_contained_same_paragraph_check(Evas_Object* o, int x1, int y1, int x2, int y2)
> 
> How about calling this ewk_frame_points_in_same_paragraph_get()?

Ok.

[Grzegorz Czajkowski]

Created attachment 96069 [details]
updated patch

Function's name has been changed to frame_points_in_same_paragraph_get

[Gyuyoung Kim]

LGTM.

[Grzegorz Czajkowski]

Created attachment 104987 [details]
updated patch

Just re-base old patch and adjust it to the current changes.

[Raphael Kubo da Costa (:rakuco)]

Comment on attachment 104987 [details]
updated patch

r- for now as at least the coding style and the documentation (the [in] and [out] are not needed) need to be adjusted.

The functions themselves look very specific to me, but that can be discussed later (it'd be good to have the opinion of someone who works on editing code, for example).

[Grzegorz Czajkowski]

Created attachment 122619 [details]
updated patch

I adjusted patch to new WebKit-Efl coding style.

[Gyuyoung Kim]

Comment on attachment 122619 [details]
updated patch

View in context: https://bugs.webkit.org/attachment.cgi?id=122619&action=review

Looks good to me except for API naming I mentioned.

> Source/WebKit/efl/ewk/ewk_frame.h:908
> +EAPI Eina_Bool ewk_frame_points_in_same_paragraph_get(const Evas_Object *o, int x1, int y1, int x2, int y2);

I'm not sure whether this API naming is good.

[Gyuyoung Kim]

Comment on attachment 122619 [details]
updated patch

Cleared review? from attachment 122619 [details] so that this bug does not appear in http://webkit.org/pending-review.  If you would like this patch reviewed, please attach it to a new bug (or re-open this bug before marking it for review again).

[Michael Catanzaro]

Closing this bug because the EFL port has been removed from trunk.

If you feel this bug applies to a different upstream WebKit port and was closed in error, please either update the title and reopen the bug, or leave a comment to request this.