Bug 61992

Summary: Show a shadow root node itself in Node::showTreeForThisAcrossFrame
Product: WebKit Reporter: Hayato Ito <hayato>
Component: DOMAssignee: Hayato Ito <hayato>
Status: RESOLVED WONTFIX    
Severity: Normal CC: rniwa, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
show shadow root itself rniwa: review+, webkit.review.bot: commit-queue-

Hayato Ito
Reported 2011-06-02 21:52:49 PDT
It's better to show a shadow root node itself for debugging. Skipping it didn't add any values.
Attachments
show shadow root itself (1.47 KB, patch)
2011-06-02 21:54 PDT, Hayato Ito
rniwa: review+
webkit.review.bot: commit-queue-
Hayato Ito
Comment 1 2011-06-02 21:54:54 PDT
Created attachment 95852 [details] show shadow root itself
WebKit Review Bot
Comment 2 2011-06-18 13:19:19 PDT
Comment on attachment 95852 [details] show shadow root itself Rejecting attachment 95852 [details] from commit-queue. Failed to run "['./Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=ec2-cq-01', '--port..." exit_code: 2 Last 500 characters of output: mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--reviewer', u'Ryosuke Niwa', u'--for..." exit_code: 1 Parsed 2 diffs from patch file(s). patching file Source/WebCore/ChangeLog Hunk #1 succeeded at 1 with fuzz 3. patching file Source/WebCore/dom/Node.cpp Hunk #1 FAILED at 2364. 1 out of 1 hunk FAILED -- saving rejects to file Source/WebCore/dom/Node.cpp.rej Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--reviewer', u'Ryosuke Niwa', u'--for..." exit_code: 1 Full output: http://queues.webkit.org/results/8878941
Hayato Ito
Comment 3 2011-06-19 22:19:15 PDT
I forgot to commit this patch, and the following patch was a superset of this patch. http://trac.webkit.org/changeset/89021 So we don't need to do any action about this patch.
Note You need to log in before you can comment on or make changes to this bug.