Bug 6196

Summary: Would like to be able to define prototypes in headers
Product: WebKit Reporter: Anders Carlsson <andersca>
Component: JavaScriptCoreAssignee: Anders Carlsson <andersca>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 420+   
Hardware: Mac   
OS: OS X 10.4   
Attachments:
Description Flags
Make it possible to use DEFINE_PROTOTYPE in headers eric: review+

Anders Carlsson
Reported 2005-12-22 06:42:59 PST
Sometimes, a JS object needs access to a prototype in a different file. An example of this is HTMLDocumentProto in kjs_html.cpp, whose prototype is currently in kjs_dom.cpp. It would be nice if we could put the prototype declaration in kjs_dom.h instead.
Attachments
Make it possible to use DEFINE_PROTOTYPE in headers (23.17 KB, patch)
2005-12-22 06:47 PST, Anders Carlsson 		eric: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Anders Carlsson
Comment 1 2005-12-22 06:47:42 PST
Created attachment 5221 [details] Make it possible to use DEFINE_PROTOTYPE in headers
Eric Seidel (no email)
Comment 2 2005-12-22 07:03:01 PST
Comment on attachment 5221 [details] Make it possible to use DEFINE_PROTOTYPE in headers Looks fine to me. r=me.
Darin Adler
Comment 3 2005-12-22 08:41:49 PST
These macros really need some kind of namespace prefix.
Note You need to log in before you can comment on or make changes to this bug.