Bug 61957

Summary: [Qt] Build fix of QtWebKit 2.2 when inside Qt tree with GCC 4.6.
Product: WebKit Reporter: Alexis Menard (darktears) <menard>
Component: WebKit QtAssignee: Alexis Menard (darktears) <menard>
Status: RESOLVED FIXED    
Severity: Blocker CC: ademar, dihan.wickremasuriya, ossy
Priority: P1 Keywords: Qt, QtTriaged
Version: 528+ (Nightly build)   
Hardware: PC   
OS: Linux   
Attachments:
Description Flags
Patch
none
Patch benjamin: review+, benjamin: commit-queue+

Alexis Menard (darktears)
Reported 2011-06-02 13:27:14 PDT
[Qt] Build fix of QtWebKit 2.2 when inside Qt tree with GCC 4.6.
Attachments
Patch (3.26 KB, patch)
2011-06-02 13:35 PDT, Alexis Menard (darktears) 		no flags
DetailsFormatted DiffDiff
Patch (4.27 KB, patch)
2011-06-03 04:48 PDT, Alexis Menard (darktears) 		benjamin: review+
benjamin: commit-queue+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Alexis Menard (darktears)
Comment 1 2011-06-02 13:35:11 PDT
Created attachment 95799 [details] Patch
Andreas Kling
Comment 2 2011-06-02 13:37:17 PDT
Comment on attachment 95799 [details] Patch r=me, brah
Alexis Menard (darktears)
Comment 3 2011-06-02 13:38:22 PDT
Committed r87950: <http://trac.webkit.org/changeset/87950>
Csaba Osztrogonác
Comment 4 2011-06-02 15:46:17 PDT
(In reply to comment #3) > Committed r87950: <http://trac.webkit.org/changeset/87950> It broke Mac build. :-/ cc1plus: error: unrecognized command line option "-Wno-c++0x-compat" Reopen to fix it.
Alexis Menard (darktears)
Comment 5 2011-06-03 02:20:12 PDT
(In reply to comment #4) > (In reply to comment #3) > > Committed r87950: <http://trac.webkit.org/changeset/87950> > > It broke Mac build. :-/ > cc1plus: error: unrecognized command line option "-Wno-c++0x-compat" > > Reopen to fix it. How is it possible? Mac runs GCC 4.6.0?
Csaba Osztrogonác
Comment 6 2011-06-03 02:35:19 PDT
I don't know ... Dihan?
Alexis Menard (darktears)
Comment 7 2011-06-03 03:55:23 PDT
And it's protected in a linux { } condition so I close it unless someone show me exactly what's going on.
Alexis Menard (darktears)
Comment 8 2011-06-03 04:48:16 PDT
Created attachment 95888 [details] Patch
Benjamin Poulain
Comment 9 2011-06-03 04:57:50 PDT
Comment on attachment 95888 [details] Patch Looks ok. Let's see if the bot likes it :)
Alexis Menard (darktears)
Comment 10 2011-06-03 05:04:53 PDT
Committed r88006: <http://trac.webkit.org/changeset/88006>
Ademar Reis
Comment 11 2011-06-03 06:44:38 PDT
Revision r87950 cherry-picked into qtwebkit-2.2 with commit cf23541 <http://gitorious.org/webkit/qtwebkit/commit/cf23541> Revision r88006 cherry-picked into qtwebkit-2.2 with commit 5902ab9 <http://gitorious.org/webkit/qtwebkit/commit/5902ab9>
Dihan Wickremasuriya
Comment 12 2011-06-03 08:49:29 PDT
(In reply to comment #6) > I don't know ... Dihan? I know this issue has been resolved, but in case anyone still needs this info the version of gcc/g++ on the Mac build slave is 4.2.1 build 5664. Detailed software/hardware specs for the Mac slave are now available on the bot: http://build.webkit.sed.hu/buildslaves/szeged-xserve-1
Note You need to log in before you can comment on or make changes to this bug.