| Summary: | Add quirk for plug-ins that return a retained CALayer | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Anders Carlsson <andersca> | ||||
| Component: | New Bugs | Assignee: | Anders Carlsson <andersca> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | simon.fraser | ||||
| Priority: | P2 | ||||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Bug Depends on: | |||||||
| Bug Blocks: | 58282 | ||||||
| Attachments: |
|
||||||
|
Description
Anders Carlsson
2011-06-02 11:39:03 PDT
Created attachment 95783 [details]
Patch
Comment on attachment 95783 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=95783&action=review > Source/WebKit2/WebProcess/Plugins/Netscape/NetscapeBrowserFuncs.cpp:418 > static const unsigned WKNVSupportsCompositingCoreAnimationPluginsBool = 74656; > > // The Core Animation render server port. > static const unsigned WKNVCALayerRenderServerPort = 71879; > > +// Whether the browser expects a non-retained Core Animation layer. > +static const unsigned WKNVExpectsNonretainedLayer = 0x574b0000; Seems odd to have a random-seeming int for WKNVSupportsCompositingCoreAnimationPluginsBool, and a large hex value for WKNVExpectsNonretainedLayer I think I'd also like to see some comments describing the history, and linking to https://bugs.webkit.org/show_bug.cgi?id=58282 A few years down the road this is going to be really hard to disentangle. And we should fix the test plugin to be spec-compliant. Committed r87945: <http://trac.webkit.org/changeset/87945> |