Bug 61948

Summary: Add quirk for plug-ins that return a retained CALayer
Product: WebKit Reporter: Anders Carlsson <andersca>
Component: New BugsAssignee: Anders Carlsson <andersca>
Status: RESOLVED FIXED    
Severity: Normal CC: simon.fraser
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 58282    
Attachments:
Description Flags
Patch simon.fraser: review+

Anders Carlsson
Reported 2011-06-02 11:39:03 PDT
Add quirk for plug-ins that return a retained CALayer
Attachments
Patch (7.53 KB, patch)
2011-06-02 11:41 PDT, Anders Carlsson 		simon.fraser: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Anders Carlsson
Comment 1 2011-06-02 11:41:35 PDT
Created attachment 95783 [details] Patch
Simon Fraser (smfr)
Comment 2 2011-06-02 11:51:51 PDT
Comment on attachment 95783 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=95783&action=review > Source/WebKit2/WebProcess/Plugins/Netscape/NetscapeBrowserFuncs.cpp:418 > static const unsigned WKNVSupportsCompositingCoreAnimationPluginsBool = 74656; > > // The Core Animation render server port. > static const unsigned WKNVCALayerRenderServerPort = 71879; > > +// Whether the browser expects a non-retained Core Animation layer. > +static const unsigned WKNVExpectsNonretainedLayer = 0x574b0000; Seems odd to have a random-seeming int for WKNVSupportsCompositingCoreAnimationPluginsBool, and a large hex value for WKNVExpectsNonretainedLayer
Simon Fraser (smfr)
Comment 3 2011-06-02 11:52:52 PDT
I think I'd also like to see some comments describing the history, and linking to https://bugs.webkit.org/show_bug.cgi?id=58282 A few years down the road this is going to be really hard to disentangle.
Simon Fraser (smfr)
Comment 4 2011-06-02 11:53:53 PDT
And we should fix the test plugin to be spec-compliant.
Anders Carlsson
Comment 5 2011-06-02 12:59:21 PDT
Committed r87945: <http://trac.webkit.org/changeset/87945>
Note You need to log in before you can comment on or make changes to this bug.