Bug 61941 – [Qt] LayoutTests/fast/dom/Window/new-window-opener.html failed

• Component: WebKit API
• Status: RESOLVED INVALID

[qi]

Need implement window.scrollbars.visible

[qi]

Created attachment 95775 [details]
patch

[Antonio Gomes]

Comment on attachment 95775 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=95775&action=review

> Source/WebKit/qt/WebCoreSupport/ChromeClientQt.cpp:268
> +    emit m_webPage->scrollBarVisibilityChangeRequested(visible);

how does this work with set scrollbar policy we have in qwebsettings API?

[qi]

My implementation followed the other similar function like change toolBar and menuBar visibility. I think here we just issue a event instead of changing the setting because we want browser ui has a ability to change the toolBar or scrollBar visibility (this request come from javascript), but browser also can ignore this event.

[Alexis Menard (darktears)]

Comment on attachment 95775 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=95775&action=review

>> Source/WebKit/qt/WebCoreSupport/ChromeClientQt.cpp:268
>> +    emit m_webPage->scrollBarVisibilityChangeRequested(visible);
> 
> how does this work with set scrollbar policy we have in qwebsettings API?

and the normal scrollbar policy of a QWidget? This API only meant to be used on QGraphicsWebView?

[Robert Hogan]

Comment on attachment 95775 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=95775&action=review

> Source/WebKit/qt/WebCoreSupport/ChromeClientQt.cpp:275
> +    return scrollBarVisible;

Shouldn't ChromeClientQt report if the client's scrollbar is actually visible or not rather than just assume it?

[Simon Hausmann]

Comment on attachment 95775 [details]
patch

I agree with the other folks. It sounds like the implementation of these two functions in ChromeClientQt should use FrameView's setCanHaveScrollbars and canHaveScrollbars. Check out the windows port for inspiration :)

I don't think new API is required.

[Jocelyn Turcotte]

=== Bulk closing of Qt bugs ===

If you believe that this bug report is still relevant for a non-Qt port of webkit.org, please re-open it and remove [Qt] from the summary.

If you believe that this is still an important QtWebKit bug, please fill a new report at https://bugreports.qt-project.org and add a link to this issue. See http://qt-project.org/wiki/ReportingBugsInQt for additional guidelines.