Summary: | jquery/manipulation.html is very slow in debug builds, frequently timing out | ||
---|---|---|---|
Product: | WebKit | Reporter: | Mario Sanchez Prada <mario> |
Component: | Tools / Tests | Assignee: | Nobody <webkit-unassigned> |
Status: | NEW --- | ||
Severity: | Normal | CC: | abarth, benjamin, cdumez, dpranke, eric, ossy, tony |
Priority: | P2 | Keywords: | Gtk, Qt, QtTriaged |
Version: | 528+ (Nightly build) | ||
Hardware: | Unspecified | ||
OS: | Linux | ||
See Also: | https://bugs.webkit.org/show_bug.cgi?id=139634 | ||
Bug Depends on: | 90970, 90968, 90969, 90971 | ||
Bug Blocks: |
Description
Mario Sanchez Prada
2011-06-02 09:06:16 PDT
It fails always on Qt 32 bit debug mode always. It is only a very very slow test, passes with --no-timeout option passed to DRT: $ time WebKitBuild/Debug/bin/DumpRenderTree LayoutTests/jquery/manipulation.html --no-timeout ALERT: 473 tests of 473 passed, 0 failed. Source: <html><head><script src="resources/helper.js"></script><style>iframe { width: 100%; height: 100%; }</style> </head><body><iframe src="resources/test/index.html?manipulation"></iframe> </body></html> Content-Type: text/plain #EOF #EOF #EOF LEAK: 76584 WebCoreNode LEAK: 26 CachedResource real 0m35.541s user 0m35.346s sys 0m0.048s But if I marked it as slow in test_expectations.txt, it still fails, because it seems SLOW directive is only for NRWT and not for DRT. :( cc NRWT guys, and Adam as the author of the test. test_expectations has a "SLOW" designation, but we may need to break up the test. (In reply to comment #4) > test_expectations has a "SLOW" designation, but we may need to break up the test. That's what I mentioned. SLOW only works in NRWT side, but it seems that NRWT doesn't pass timeout to the DRT and DRT exits early with notifydone timeout after 30 secs independetly of SLOW directive in test_expectations.txt (In reply to comment #5) > (In reply to comment #4) > > test_expectations has a "SLOW" designation, but we may need to break up the test. > > That's what I mentioned. SLOW only works in NRWT side, but it seems that > NRWT doesn't pass timeout to the DRT and DRT exits early with notifydone > timeout after 30 secs independetly of SLOW directive in test_expectations.txt That's a problem, obviously. Either DRT needs to have no timeout or we need to pass a timeout to it that it honors. I have a workaround for this bug if the given DRT supports --timeout option. Now only Qt port do it ... but it is buggy a little bit, but will be fixed soon: https://bugs.webkit.org/show_bug.cgi?id=90966 You have to pass the following arguments to NRWT: --additional-drt-flag=--timeout --additional-drt-flag=50000 --time-out-ms=50000 But unfortunately you have to modify the master.cfg to do it on the buildbot. :-/ Mac is affected too. I'm going to mark the test as slow, and then we can see if something else needs to be done for other timeout guards. |