| Summary: | layout test for misalignment caused by float->int rounding error | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | David Grogan <dgrogan> | ||||||
| Component: | New Bugs | Assignee: | David Grogan <dgrogan> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | eae, eric, leviw, logingx, webkit.review.bot | ||||||
| Priority: | P2 | ||||||||
| Version: | 528+ (Nightly build) | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Bug Depends on: | |||||||||
| Bug Blocks: | 22759, 60318 | ||||||||
| Attachments: |
|
||||||||
|
Description
David Grogan
2011-06-01 23:07:53 PDT
Created attachment 95726 [details]
Patch
Eric, can you take a look at this? Comment on attachment 95726 [details]
Patch
Looks OK. Does FF and IE pass this test (aka do we know it's a valid test?)
FF passes. It returns a float for the top and bottom that is ~31.55. I don't know about IE. Levi or Emil, do either of you guys have a windows machine? Or know where I can rdesktop into one? (In reply to comment #4) > FF passes. It returns a float for the top and bottom that is ~31.55. > > I don't know about IE. Levi or Emil, do either of you guys have a windows machine? Or know where I can rdesktop into one? It'd be handy if you uploaded the layout test itself for easy testin' :) There is no gap between the divs (the gap being the root cause of the problem on ebuyer.com) on either FF or IE. Oddly, the top div on IE extends into the bottom div. Webkit: top.bottom = 29 bottom.top = 31 FF: top.bottom =~ 31.35 bottom.top =~ 31.37 IE 8/9: top.bottom = 32 bottom.top = 31 Created attachment 97396 [details]
Just the layout test
(In reply to comment #7) > Created an attachment (id=97396) [details] > Just the layout test Alternatively, to have the resources resolved properly: http://goto.google.com/vnibh Apologies to non-googlers. Eric and Levi, Are you guys ok with me submitting this? Comment on attachment 95726 [details]
Patch
I like tests! :)
Comment on attachment 95726 [details] Patch Clearing flags on attachment: 95726 Committed r89176: <http://trac.webkit.org/changeset/89176> All reviewed patches have been landed. Closing bug. |