|Summary:||layout test for misalignment caused by float->int rounding error|
|Product:||WebKit||Reporter:||David Grogan <dgrogan>|
|Component:||New Bugs||Assignee:||David Grogan <dgrogan>|
|Severity:||Normal||CC:||eae, eric, leviw, logingx, webkit.review.bot|
|Version:||528+ (Nightly build)|
|Bug Depends on:|
|Bug Blocks:||22759, 60318|
Description David Grogan 2011-06-01 23:07:53 PDT
layout test for misalignment caused by float->int rounding error
Comment 2 David Grogan 2011-06-01 23:21:32 PDT
Eric, can you take a look at this?
Comment 3 Eric Seidel (no email) 2011-06-02 07:04:48 PDT
Comment on attachment 95726 [details] Patch Looks OK. Does FF and IE pass this test (aka do we know it's a valid test?)
Comment 4 David Grogan 2011-06-02 10:33:43 PDT
FF passes. It returns a float for the top and bottom that is ~31.55. I don't know about IE. Levi or Emil, do either of you guys have a windows machine? Or know where I can rdesktop into one?
Comment 5 Levi Weintraub 2011-06-02 11:12:55 PDT
(In reply to comment #4) > FF passes. It returns a float for the top and bottom that is ~31.55. > > I don't know about IE. Levi or Emil, do either of you guys have a windows machine? Or know where I can rdesktop into one? It'd be handy if you uploaded the layout test itself for easy testin' :)
Comment 6 David Grogan 2011-06-02 12:11:00 PDT
There is no gap between the divs (the gap being the root cause of the problem on ebuyer.com) on either FF or IE. Oddly, the top div on IE extends into the bottom div. Webkit: top.bottom = 29 bottom.top = 31 FF: top.bottom =~ 31.35 bottom.top =~ 31.37 IE 8/9: top.bottom = 32 bottom.top = 31
Comment 7 David Grogan 2011-06-15 21:37:28 PDT
Created attachment 97396 [details] Just the layout test
Comment 8 David Grogan 2011-06-15 21:44:59 PDT
(In reply to comment #7) > Created an attachment (id=97396) [details] > Just the layout test Alternatively, to have the resources resolved properly: http://goto.google.com/vnibh Apologies to non-googlers.
Comment 9 David Grogan 2011-06-17 14:01:06 PDT
Eric and Levi, Are you guys ok with me submitting this?
Comment 10 Eric Seidel (no email) 2011-06-17 14:37:40 PDT
Comment on attachment 95726 [details] Patch I like tests! :)
Comment 11 WebKit Review Bot 2011-06-17 15:18:22 PDT
Comment on attachment 95726 [details] Patch Clearing flags on attachment: 95726 Committed r89176: <http://trac.webkit.org/changeset/89176>
Comment 12 WebKit Review Bot 2011-06-17 15:18:27 PDT
All reviewed patches have been landed. Closing bug.