Bug 61879

Summary:

Add single character lookup cache to IdentifierArena

Product:

WebKit

Reporter:

Oliver Hunt <oliver>

Component:

New Bugs

Assignee:

Oliver Hunt <oliver>

Status:

RESOLVED FIXED

Severity:

Normal

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	ggaren: review+

Description Oliver Hunt 2011-06-01 12:59:07 PDT

Add single character lookup cache to IdentifierArena

Comment 1 Oliver Hunt 2011-06-01 13:00:29 PDT

Created attachment 95646 [details]
Patch

Comment 2 Geoffrey Garen 2011-06-01 13:07:09 PDT

Comment on attachment 95646 [details]
Patch

r=me

Comment 3 Oliver Hunt 2011-06-01 13:10:00 PDT

Committed r87838: <http://trac.webkit.org/changeset/87838>

Comment 4 Adam Roben (:aroben) 2011-06-01 13:11:43 PDT

Comment on attachment 95646 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=95646&action=review

> Source/JavaScriptCore/parser/ParserArena.h:51
> +            for (unsigned  i = 0; i < 128; i++)

You should use the constant! And maybe size_t.

> Source/JavaScriptCore/parser/ParserArena.h:57
> +        static const int MaximumCachableCharacter = 128;

Missing an "e" in there: "cacheable".