Bug 61879

Summary: Add single character lookup cache to IdentifierArena
Product: WebKit Reporter: Oliver Hunt <oliver>
Component: New BugsAssignee: Oliver Hunt <oliver>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch ggaren: review+

Oliver Hunt
Reported 2011-06-01 12:59:07 PDT
Add single character lookup cache to IdentifierArena
Attachments
Patch (2.74 KB, patch)
2011-06-01 13:00 PDT, Oliver Hunt 		ggaren: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Oliver Hunt
Comment 1 2011-06-01 13:00:29 PDT
Created attachment 95646 [details] Patch
Geoffrey Garen
Comment 2 2011-06-01 13:07:09 PDT
Comment on attachment 95646 [details] Patch r=me
Oliver Hunt
Comment 3 2011-06-01 13:10:00 PDT
Committed r87838: <http://trac.webkit.org/changeset/87838>
Adam Roben (:aroben)
Comment 4 2011-06-01 13:11:43 PDT
Comment on attachment 95646 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=95646&action=review > Source/JavaScriptCore/parser/ParserArena.h:51 > + for (unsigned i = 0; i < 128; i++) You should use the constant! And maybe size_t. > Source/JavaScriptCore/parser/ParserArena.h:57 > + static const int MaximumCachableCharacter = 128; Missing an "e" in there: "cacheable".
Note You need to log in before you can comment on or make changes to this bug.