Bug 61848

Summary:

Implement video full-srceen API in WebKit2

Product:

WebKit

Reporter:

Jer Noble <jer.noble>

Component:

WebKit2

Assignee:

Jer Noble <jer.noble>

Status:

RESOLVED WONTFIX

Severity:

Normal

CC:

aestes, eric.carlson, eric, simon.fraser, webkit.review.bot

Priority:

Keywords:

InRadar

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

61843

Bug Blocks:

Attachments:

Description	Flags
Patch	none
[PATCH 1/4] Added new class: WebVideoFullScreenManager	none
[PATCH 2/4] Added new class: WebVideoFullScreenManagerProxy	none
[PATCH 3/4] Add new classes to project, and add support for their	eric: commit-queue-
[PATCH 4/4] Enable video full-screen mode in WebKit2/mac.	eric: commit-queue-

Jer Noble

Reported 2011-06-01 01:52:01 PDT

Implement video full-srceen API in WebKit2

Attachments
Patch (77.43 KB, patch) 2011-06-01 02:46 PDT, Jer Noble	no flags	Details Formatted Diff Diff
[PATCH 1/4] Added new class: WebVideoFullScreenManager (39.04 KB, patch) 2011-06-01 14:18 PDT, Jer Noble	no flags	Details Formatted Diff Diff
[PATCH 2/4] Added new class: WebVideoFullScreenManagerProxy (33.10 KB, patch) 2011-06-01 14:19 PDT, Jer Noble	no flags	Details Formatted Diff Diff
[PATCH 3/4] Add new classes to project, and add support for their (21.10 KB, patch) 2011-06-01 14:19 PDT, Jer Noble	eric: commit-queue-	Details Formatted Diff Diff
[PATCH 4/4] Enable video full-screen mode in WebKit2/mac. (5.05 KB, patch) 2011-06-01 14:20 PDT, Jer Noble	eric: commit-queue-	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Jer Noble

Comment 1 2011-06-01 02:46:08 PDT

Created attachment 95571 [details] Patch This patch enables video full-screen mode (i.e. webkitEnterFullscreen) in WebKit2 on mac, supporting both QTKit and AVFoundation.

Jer Noble

Comment 2 2011-06-01 14:18:43 PDT

Created attachment 95660 [details] [PATCH 1/4] Added new class: WebVideoFullScreenManager

Jer Noble

Comment 3 2011-06-01 14:19:19 PDT

Created attachment 95661 [details] [PATCH 2/4] Added new class: WebVideoFullScreenManagerProxy

Jer Noble

Comment 4 2011-06-01 14:19:56 PDT

Created attachment 95662 [details] [PATCH 3/4] Add new classes to project, and add support for their

Jer Noble

Comment 5 2011-06-01 14:20:21 PDT

Created attachment 95663 [details] [PATCH 4/4] Enable video full-screen mode in WebKit2/mac.

WebKit Review Bot

Comment 6 2011-06-01 14:20:47 PDT

Attachment 95660 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit2/ChangeLog', u'Source/WebKit..." exit_code: 1 Source/WebKit2/WebProcess/FullScreen/mac/WebVideoFullScreenManagerMac.h:41: Code inside a namespace should not be indented. [whitespace/indent] [4] Source/WebKit2/WebProcess/FullScreen/WebVideoFullScreenManager.h:35: Code inside a namespace should not be indented. [whitespace/indent] [4] Total errors found: 2 in 6 files If any of these errors are false positives, please file a bug against check-webkit-style.

WebKit Review Bot

Comment 7 2011-06-01 14:21:55 PDT

Attachment 95661 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit2/ChangeLog', u'Source/WebKit..." exit_code: 1 Source/WebKit2/UIProcess/FullScreen/WebVideoFullScreenManagerProxy.h:35: Code inside a namespace should not be indented. [whitespace/indent] [4] Total errors found: 1 in 6 files If any of these errors are false positives, please file a bug against check-webkit-style.

Jer Noble

Comment 8 2011-06-01 14:28:58 PDT

<rdar://problem/9522985>

Eric Seidel (no email)

Comment 9 2011-06-02 08:38:05 PDT

Who should be CC'd to review these?

Eric Seidel (no email)

Comment 10 2011-06-04 08:52:56 PDT

Comment on attachment 95662 [details] [PATCH 3/4] Add new classes to project, and add support for their Attachment 95662 [details] did not pass mac-ews (mac): Output: http://queues.webkit.org/results/8651089

Eric Seidel (no email)

Comment 11 2011-06-04 08:54:27 PDT

Comment on attachment 95663 [details] [PATCH 4/4] Enable video full-screen mode in WebKit2/mac. Attachment 95663 [details] did not pass mac-ews (mac): Output: http://queues.webkit.org/results/8766376

Eric Seidel (no email)

Comment 12 2012-01-30 15:22:16 PST

Looks like this was forgotten?

Jer Noble

Comment 13 2012-01-30 15:27:13 PST

Yes, I'll clear the r? flags and mark this as not-to-be-fixed.

Note You need to log in before you can comment on or make changes to this bug.