Summary: | Implement video full-srceen API in WebKit2 | ||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Jer Noble <jer.noble> | ||||||||||||
Component: | WebKit2 | Assignee: | Jer Noble <jer.noble> | ||||||||||||
Status: | RESOLVED WONTFIX | ||||||||||||||
Severity: | Normal | CC: | aestes, eric.carlson, eric, simon.fraser, webkit.review.bot | ||||||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||||||
Version: | 528+ (Nightly build) | ||||||||||||||
Hardware: | Unspecified | ||||||||||||||
OS: | Unspecified | ||||||||||||||
Bug Depends on: | 61843 | ||||||||||||||
Bug Blocks: | |||||||||||||||
Attachments: |
|
Description
Jer Noble
2011-06-01 01:52:01 PDT
Created attachment 95571 [details]
Patch
This patch enables video full-screen mode (i.e. webkitEnterFullscreen) in WebKit2 on mac, supporting both QTKit and AVFoundation.
Created attachment 95660 [details]
[PATCH 1/4] Added new class: WebVideoFullScreenManager
Created attachment 95661 [details]
[PATCH 2/4] Added new class: WebVideoFullScreenManagerProxy
Created attachment 95662 [details]
[PATCH 3/4] Add new classes to project, and add support for their
Created attachment 95663 [details]
[PATCH 4/4] Enable video full-screen mode in WebKit2/mac.
Attachment 95660 [details] did not pass style-queue:
Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit2/ChangeLog', u'Source/WebKit..." exit_code: 1
Source/WebKit2/WebProcess/FullScreen/mac/WebVideoFullScreenManagerMac.h:41: Code inside a namespace should not be indented. [whitespace/indent] [4]
Source/WebKit2/WebProcess/FullScreen/WebVideoFullScreenManager.h:35: Code inside a namespace should not be indented. [whitespace/indent] [4]
Total errors found: 2 in 6 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Attachment 95661 [details] did not pass style-queue:
Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit2/ChangeLog', u'Source/WebKit..." exit_code: 1
Source/WebKit2/UIProcess/FullScreen/WebVideoFullScreenManagerProxy.h:35: Code inside a namespace should not be indented. [whitespace/indent] [4]
Total errors found: 1 in 6 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Who should be CC'd to review these? Comment on attachment 95662 [details] [PATCH 3/4] Add new classes to project, and add support for their Attachment 95662 [details] did not pass mac-ews (mac): Output: http://queues.webkit.org/results/8651089 Comment on attachment 95663 [details] [PATCH 4/4] Enable video full-screen mode in WebKit2/mac. Attachment 95663 [details] did not pass mac-ews (mac): Output: http://queues.webkit.org/results/8766376 Looks like this was forgotten? Yes, I'll clear the r? flags and mark this as not-to-be-fixed. |