Bug 61823

Summary: [Chromium] webkitStorageInfo methods (for quota API) should not crash when error callback is not given.
Product: WebKit Reporter: Kinuko Yasuda <kinuko>
Component: WebKit Misc.Assignee: Kinuko Yasuda <kinuko>
Status: RESOLVED FIXED    
Severity: Normal CC: fishd, levin, michaeln
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch tkent: review+

Description Kinuko Yasuda 2011-05-31 17:25:30 PDT 
[Chromium] webkitStorageInfo methods (for quota API) should not crash when error callback is not given.

webkitStorageInfo.queryUsageAndQuota() and webkitStorageInfo.requestQuota() take error callback as optional argument, but it crashes when null is given as the error callback.
Comment 1 Kinuko Yasuda 2011-05-31 17:29:10 PDT 
Created attachment 95518 [details]
Patch
Comment 2 Kent Tamura 2011-05-31 17:49:05 PDT 
Comment on attachment 95518 [details]
Patch

Why the patch has no test?
Comment 3 Kinuko Yasuda 2011-05-31 20:57:21 PDT 
Created attachment 95542 [details]
Patch
Comment 4 Kinuko Yasuda 2011-05-31 20:58:30 PDT 
Added tests. (We have not added DRT/test-shell support for quota API yet and it is chromium-only fix, so the test is currently marked to be skipped everywhere for now.)
Comment 5 Kent Tamura 2011-05-31 21:01:43 PDT 
Comment on attachment 95542 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=95542&action=review

> LayoutTests/ChangeLog:18
> +        * storage/storageinfo-query-usage.html: Removed unnecessary js inclusion.
> +        * storage/storageinfo-request-quota.html: Removed unnecessary js inclusion.

Are they related to this bug?

> LayoutTests/storage/storageinfo-no-callbacks.html:9
> +<script src="script-tests/storageinfo-no-callbacks.js"></script>

nit: We may merge the .js file to this.
Comment 6 Kinuko Yasuda 2011-05-31 21:26:44 PDT 
Created attachment 95544 [details]
Patch
Comment 7 Kent Tamura 2011-05-31 21:29:36 PDT 
Comment on attachment 95544 [details]
Patch

ok
Comment 8 Kinuko Yasuda 2011-05-31 22:10:12 PDT 
Committed r87772: <http://trac.webkit.org/changeset/87772>