Summary: | [V8] Optimize fetches of indexed properties in custom bindings | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Kenneth Russell <kbr> | ||||||
Component: | WebGL | Assignee: | Kenneth Russell <kbr> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | dglazkov, jamesr, japhet, levin | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Attachments: |
|
Description
Kenneth Russell
2011-05-31 16:55:06 PDT
The associated Chromium bug report is http://crbug.com/84007 . Created attachment 95513 [details]
Patch
Comment on attachment 95513 [details]
Patch
LGTM
Comment on attachment 95513 [details]
Patch
This is fine, though I notice that there are several other places in the v8 bindings where we are still using the the Get() variant you're removing here. Is there any reason we shouldn't change those too?
Good point. I've updated the synopsis and will upload a new patch shortly. Created attachment 95644 [details]
Patch
Comment on attachment 95644 [details]
Patch
Great, thanks!
"webkit-patch land" hung. Committed as http://trac.webkit.org/changeset/87837 . |