Bug 61819

Summary:

nrwt: make webaudio work w/o content-length header

Product:

WebKit

Reporter:

Dirk Pranke <dpranke>

Component:

New Bugs

Assignee:

Dirk Pranke <dpranke>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

abarth, ademar, crogers, eric, ojan, tony

Priority:

Version:

528+ (Nightly build)

Hardware:

OS:

All

Attachments:

Description	Flags
Patch	none
restore newlines in DRT output	none
update patch w/ feedback from Tony	none

Dirk Pranke

Reported 2011-05-31 16:25:48 PDT

nrwt: make webaudio work w/o content-length header

Attachments
Patch (6.32 KB, patch) 2011-05-31 16:27 PDT, Dirk Pranke	no flags	Details Formatted Diff Diff
restore newlines in DRT output (6.35 KB, patch) 2011-05-31 17:22 PDT, Dirk Pranke	no flags	Details Formatted Diff Diff
update patch w/ feedback from Tony (6.73 KB, patch) 2011-06-01 14:05 PDT, Dirk Pranke	no flags	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

Dirk Pranke

Comment 1 2011-05-31 16:27:42 PDT

Created attachment 95506 [details] Patch

Dirk Pranke

Comment 2 2011-05-31 16:34:00 PDT

This patch reworks the logic used by the webkit implementations for parsing the output from DRT. Chromium uses a completely different mechanism for audio so it isn't affected. Testing this revealed related issues with --print trace-everything and the mock_drt implementation that weren't handling audio properly, so those have been rolled into this as well.

Dirk Pranke

Comment 3 2011-05-31 17:22:18 PDT

Created attachment 95517 [details] restore newlines in DRT output

Tony Chang

Comment 4 2011-06-01 09:48:40 PDT

Comment on attachment 95517 [details] restore newlines in DRT output View in context: https://bugs.webkit.org/attachment.cgi?id=95517&action=review > Tools/Scripts/webkitpy/layout_tests/layout_package/printing.py:319 > + self._print_baseline(filename, '.txt') > + self._print_baseline(filename, '.wav') > + self._print_baseline(filename, '.png') Nit: Maybe make this a for loop (one less line of code)? > Tools/Scripts/webkitpy/layout_tests/layout_package/single_test_runner.py:150 > + if driver_output.text: > + self._save_baseline_data(driver_output.text, ".txt", Nit: Should we just have _safe_baseline_data bail out if the first param is None?

Dirk Pranke

Comment 5 2011-06-01 10:31:54 PDT

Comment on attachment 95517 [details] restore newlines in DRT output View in context: https://bugs.webkit.org/attachment.cgi?id=95517&action=review >> Tools/Scripts/webkitpy/layout_tests/layout_package/printing.py:319 >> + self._print_baseline(filename, '.png') > > Nit: Maybe make this a for loop (one less line of code)? Will do. >> Tools/Scripts/webkitpy/layout_tests/layout_package/single_test_runner.py:150 >> + self._save_baseline_data(driver_output.text, ".txt", > > Nit: Should we just have _safe_baseline_data bail out if the first param is None? Will do. I think it's a bit of a toss-up which way is clearer.

Dirk Pranke

Comment 6 2011-06-01 14:05:34 PDT

Created attachment 95658 [details] update patch w/ feedback from Tony

Dirk Pranke

Comment 7 2011-06-01 14:09:14 PDT

Committed r87847: <http://trac.webkit.org/changeset/87847>

Ademar Reis

Comment 8 2011-06-03 14:00:56 PDT

Revision r87847 cherry-picked into qtwebkit-2.2 with commit c783730 <http://gitorious.org/webkit/qtwebkit/commit/c783730>

Note You need to log in before you can comment on or make changes to this bug.