Bug 61812

Summary:

TestWebKitApi breaks in release mode due to gtest incompatibility with fast malloc

Product:

WebKit

Reporter:

Dmitry Lomov <dslomov>

Component:

Tools / Tests

Assignee:

Dmitry Lomov <dslomov>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

dglazkov, dslomov, eric, levin

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

57513, 65706

Attachments:

Description	Flags
This disables global fast malloc for TestWebKitAPI.	eric: review-
Only disable fast malloc for offending class in GTest	levin: review+, levin: commit-queue-

Description Dmitry Lomov 2011-05-31 15:18:02 PDT

TestWebkitAPI crashes on startup in release mode due to malloc/free mismatch:
- TestWebKitAPI is compiled with fast malloc for all 
- gtest uses system malloc.

Comment 1 Dmitry Lomov 2011-05-31 15:30:42 PDT

Created attachment 95494 [details]
This disables global fast malloc for TestWebKitAPI.

Comment 2 David Levin 2011-05-31 16:25:55 PDT

It would be nice to explain this a bit more. Not a lot, just enough so that someone who looks at this (in the future) to understand why this was done would be able to see the problem. Then they could determine if it is still needed, etc.

Comment 3 Eric Seidel (no email) 2011-06-02 08:41:07 PDT

Comment on attachment 95494 [details]
This disables global fast malloc for TestWebKitAPI.

This needs a comment.  Otherwise folks won't understand why we have that line there.

Comment 4 Dmitry Lomov 2011-06-02 11:40:35 PDT

(In reply to comment #3)
> (From update of attachment 95494 [details])
> This needs a comment.  Otherwise folks won't understand why we have that line there.

Yeah I am convinced now that it is not a good fix. Sorry for the noise

Comment 5 Eric Seidel (no email) 2011-06-13 15:16:03 PDT

Sounds like this is WONTFIX then.

Comment 6 Eric Seidel (no email) 2011-06-13 15:16:30 PDT

Oh, nevermind.  You're planning to fix this some other way.

Comment 7 Dmitry Lomov 2011-08-03 21:23:46 PDT

Created attachment 102873 [details]
Only disable fast malloc for offending class in GTest

Comment 8 David Levin 2011-08-03 21:38:06 PDT

Comment on attachment 102873 [details]
Only disable fast malloc for offending class in GTest

Given that this is in GTest, I guess it should follow their style for indenting. (It doesn't follow WebKit's style either). Other than it looks fine.

Comment 9 Dmitry Lomov 2011-08-04 10:54:01 PDT

Landed in http://trac.webkit.org/changeset/92387. Closing bug.