Bug 61790

Summary: [Chromium] Build fails when ACCELERATED_2D_CANVAS is disabled
Product: WebKit Reporter: Justin Novosad <junov>
Component: Layout and RenderingAssignee: Justin Novosad <junov>
Status: RESOLVED FIXED    
Severity: Normal CC: senorblanco, vangelis
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch senorblanco: review+

Justin Novosad
Reported 2011-05-31 09:23:44 PDT
Builds currently fails with unresolved symbols if accelerated 2d canvas is disabled It looks like the ACCELERATED_COMPOSITING feature depends on symbols that are guarded by #if ENABLE(ACCELERATED_2D_CANVAS) This needs to be correct so that Chromium mac builds can be performed without the accelerated 2d canvas feature
Attachments
Patch (1.56 KB, patch)
2011-05-31 09:38 PDT, Justin Novosad 		no flags
DetailsFormatted DiffDiff
Patch (1.62 KB, patch)
2011-05-31 10:40 PDT, Justin Novosad 		senorblanco: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Justin Novosad
Comment 1 2011-05-31 09:38:20 PDT
Created attachment 95443 [details] Patch
Stephen White
Comment 2 2011-05-31 10:12:48 PDT
Comment on attachment 95443 [details] Patch Hmm. This doesn't look right to me. The ACCELERATED_2D_CANVAS guard should be correct. Could we figure out who is using these classes that is not protected by ACCELERATED_2D_CANVAS guard?
Stephen White
Comment 3 2011-05-31 10:19:29 PDT
(In reply to comment #2) > (From update of attachment 95443 [details]) > Hmm. This doesn't look right to me. The ACCELERATED_2D_CANVAS guard should be correct. Could we figure out who is using these classes that is not protected by ACCELERATED_2D_CANVAS guard? Just to answer my own question: it looks like the compositor is using TilingData (in LayerTilerChromium), so that change is correct. Justin is going to change it to (USE(ACCELERATED_COMPOSITING) || ENABLE(ACCELERATED_2D_CANVAS)) just to be on the safe side (in case someone tries to compile accel 2D canvas without the compositor). The LoopBlinnMathUtils one is a little more perplexing; Jeff and Justin are still looking into it.
Justin Novosad
Comment 4 2011-05-31 10:40:34 PDT
Created attachment 95451 [details] Patch
Stephen White
Comment 5 2011-05-31 10:55:21 PDT
Comment on attachment 95451 [details] Patch Looks good. r=me
Vangelis Kokkevis
Comment 6 2011-05-31 10:58:21 PDT
(In reply to comment #3) > (In reply to comment #2) > > (From update of attachment 95443 [details] [details]) > > Hmm. This doesn't look right to me. The ACCELERATED_2D_CANVAS guard should be correct. Could we figure out who is using these classes that is not protected by ACCELERATED_2D_CANVAS guard? > > Just to answer my own question: it looks like the compositor is using TilingData (in LayerTilerChromium), so that change is correct. Justin is going to change it to (USE(ACCELERATED_COMPOSITING) || ENABLE(ACCELERATED_2D_CANVAS)) just to be on the safe side (in case someone tries to compile accel 2D canvas without the compositor). > > The LoopBlinnMathUtils one is a little more perplexing; Jeff and Justin are still looking into it. The compositor (CCLayerSorter.cpp specifically) is using LoopBlinnMathUtils
Stephen White
Comment 7 2011-05-31 11:18:35 PDT
Comment on attachment 95451 [details] Patch We'll be back after these messages.
Stephen White
Comment 8 2011-05-31 12:24:58 PDT
Comment on attachment 95451 [details] Patch ... and we're back!
Stephen White
Comment 9 2011-05-31 13:22:06 PDT
Committed r87748: <http://trac.webkit.org/changeset/87748>
Note You need to log in before you can comment on or make changes to this bug.