Bug 61785

Summary: [WK2] Create a general wk2 specific LayoutTests/platform/wk2 platform
Product: WebKit Reporter: Csaba Osztrogonác <ossy>
Component: Tools / TestsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: abecsi, andersca, cshu, eric, jturcotte, kbalazs, kkristof, laszlo.gombos, ossy, qi.2.zhang, sam, zoltan
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 61644, 63780    
Attachments:
Description Flags
[WK2] Create a general wk2 specific LayoutTests/platform/wk2 platform
ossy: review-, ossy: commit-queue-
[WK2] Create a general wk2 specific LayoutTests/platform/wk2 platform
ossy: review-, ossy: commit-queue-
[WK2] Create a general wk2 specific LayoutTests/platform/wk2 platform
none
[WK2] Create a general wk2 specific LayoutTests/platform/wk2 platform
none
[WK2] Create a general wk2 specific LayoutTests/platform/wk2 platform none

Csaba Osztrogonác
Reported 2011-05-31 07:30:13 PDT
Now we have mac-wk2, win-wk2 and qt-wk2 WebKit2 platforms. mac-wk2/Skipped list are used for win-wk2 and qt-wk2 platforms too. It is confusing a little bit for developers, so it would be better if we use a general wk2/Skipped list instead of mac-wk2/Skipped to disable tests which need layoutTestController, eventSender implementation or tests fail because of general WebKit2 bugs. What do you think about it?
Attachments
[WK2] Create a general wk2 specific LayoutTests/platform/wk2 platform (100.00 KB, patch)
2011-06-28 04:40 PDT, Fehér Zsolt 		ossy: review-
ossy: commit-queue-
DetailsFormatted DiffDiff
[WK2] Create a general wk2 specific LayoutTests/platform/wk2 platform (98.50 KB, patch)
2011-06-28 04:41 PDT, Fehér Zsolt 		ossy: review-
ossy: commit-queue-
DetailsFormatted DiffDiff
[WK2] Create a general wk2 specific LayoutTests/platform/wk2 platform (100.90 KB, patch)
2011-06-29 03:39 PDT, Fehér Zsolt 		no flags
DetailsFormatted DiffDiff
[WK2] Create a general wk2 specific LayoutTests/platform/wk2 platform (102.06 KB, patch)
2011-06-29 03:47 PDT, Fehér Zsolt 		no flags
DetailsFormatted DiffDiff
[WK2] Create a general wk2 specific LayoutTests/platform/wk2 platform (202.88 KB, patch)
2011-06-29 04:35 PDT, Fehér Zsolt 		no flags
DetailsFormatted DiffDiff
Show Obsolete (5) View All Add attachment proposed patch, testcase, etc.
Balazs Kelemen
Comment 1 2011-05-31 07:35:34 PDT
Sounds reasonable.
Fehér Zsolt
Comment 2 2011-06-28 04:40:08 PDT
Created attachment 98898 [details] [WK2] Create a general wk2 specific LayoutTests/platform/wk2 platform
Fehér Zsolt
Comment 3 2011-06-28 04:41:01 PDT
Created attachment 98899 [details] [WK2] Create a general wk2 specific LayoutTests/platform/wk2 platform
Csaba Osztrogonác
Comment 4 2011-06-28 05:02:35 PDT
Comment on attachment 98898 [details] [WK2] Create a general wk2 specific LayoutTests/platform/wk2 platform r-, because we need only one patch. And I don't think if changes in Tools/Scripts/old-run-webkit-tests will be enough. There are many other occurances of mac-wk in ORWT script. Kristóf, you experimented with it, what do you think about it?
Csaba Osztrogonác
Comment 5 2011-06-28 05:04:03 PDT
And please use git diff -M to detect file renaming.
Balazs Kelemen
Comment 6 2011-06-28 05:48:36 PDT
(In reply to comment #4) > (From update of attachment 98898 [details]) > r-, because we need only one patch. And I don't think if changes in Tools/Scripts/old-run-webkit-tests > will be enough. There are many other occurances of mac-wk in ORWT script. Kristóf, you experimented with it, > what do you think about it? The $platform variable will still contain "mac-wk2" so there is no need to patch every place where is it used. We can assure that the patch is correct by comparing the set of tests that we run with and without it - those should be identical.
Fehér Zsolt
Comment 7 2011-06-29 03:39:51 PDT
Created attachment 99066 [details] [WK2] Create a general wk2 specific LayoutTests/platform/wk2 platform
Fehér Zsolt
Comment 8 2011-06-29 03:47:34 PDT
Created attachment 99067 [details] [WK2] Create a general wk2 specific LayoutTests/platform/wk2 platform
Fehér Zsolt
Comment 9 2011-06-29 04:35:55 PDT
Created attachment 99071 [details] [WK2] Create a general wk2 specific LayoutTests/platform/wk2 platform
Csaba Osztrogonác
Comment 10 2011-06-30 09:28:01 PDT
Comment on attachment 99071 [details] [WK2] Create a general wk2 specific LayoutTests/platform/wk2 platform LGTM, r=me.
Csaba Osztrogonác
Comment 11 2011-06-30 09:29:34 PDT
Comment on attachment 99071 [details] [WK2] Create a general wk2 specific LayoutTests/platform/wk2 platform Landed in http://trac.webkit.org/changeset/90125
Eric Seidel (no email)
Comment 12 2011-06-30 20:07:00 PDT
Fixed NRWT in bug 63780.
Note You need to log in before you can comment on or make changes to this bug.