|Summary:||[Chromium] REGRESSION: Crash in WebCore::HTMLLinkElement::onloadTimerFired after r87628|
|Product:||WebKit||Reporter:||Mikhail Naganov <mnaganov>|
|Component:||DOM||Assignee:||Mikhail Naganov <mnaganov>|
|Version:||528+ (Nightly build)|
|Bug Depends on:||61736|
Description Mikhail Naganov 2011-05-30 09:31:32 PDT
Having r87628 in place, Chrome reliability bot crashes in WebCore::HTMLLinkElement::onloadTimerFired http://build.chromium.org/p/chromium/builders/Win%20Reliability/builds/4073/steps/reliability%3A%20partial%20result%20of%20current%20build/logs/stdio This is because the change makes WebCore::CachedResource::setRequest to call checkNotify on request reset. HTMLLinkElement registers itself as CachedResource client via m_cachedSheet, which can happen even if m_cachedLinkResource wasn't set. As a result, WebCore::HTMLLinkElement::notifyFinished is got called with unset m_cachedLinkResource, which causes a crash in HTMLLinkElement::onloadTimerFired
Comment 2 Adam Barth 2011-05-30 09:54:43 PDT
Comment on attachment 95348 [details] patch I'm not sure this patch is correct. Why is notifyFinished being called with a different cached resource?
Comment 4 Adam Barth 2011-05-30 10:19:12 PDT
I'm going to land this patch without a test because this is blocking WebKit => Chromium integration. I'll add the test in Bug 61736.
Comment 5 Adam Barth 2011-05-30 10:21:19 PDT
Committed r87693: <http://trac.webkit.org/changeset/87693>
Comment 6 Alexey Proskuryakov 2011-05-30 12:29:26 PDT
Thanks Adam! I don't have the time to deeply investigate this right now, but the patch looks very reasonable.