Bug 61704

Summary:

Some heap refactoring

Product:

WebKit

Reporter:

Geoffrey Garen <ggaren>

Component:

New Bugs

Assignee:

Geoffrey Garen <ggaren>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

bfulgham, oliver

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	none

Geoffrey Garen

Reported 2011-05-29 12:40:40 PDT

Some heap refactoring

Attachments
Patch (16.01 KB, patch) 2011-05-29 12:43 PDT, Geoffrey Garen	no flags	Details Formatted Diff Diff
Patch (16.92 KB, patch) 2011-05-29 12:55 PDT, Geoffrey Garen	no flags	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Geoffrey Garen

Comment 1 2011-05-29 12:43:59 PDT

Created attachment 95290 [details] Patch

Geoffrey Garen

Comment 2 2011-05-29 12:55:26 PDT

Created attachment 95293 [details] Patch

Geoffrey Garen

Comment 3 2011-05-29 12:55:41 PDT

Giving the Windows EWS bot another go at things.

Geoffrey Garen

Comment 4 2011-05-29 14:56:57 PDT

Committed r87653: <http://trac.webkit.org/changeset/87653>

Brent Fulgham

Comment 5 2011-05-31 15:33:17 PDT

This is failing to build on the WinCairo builder. 2>------ Build started: Project: JavaScriptCore, Configuration: Debug_Cairo_CFLite Win32 ------ 2>Performing Pre-Build Event... 2>/usr/bin/bash 2>Performing Pre-Link Event... 2>Linking... 2> Creating library D:\Projects\BuildSlave\win-cairo-debug\build\WebKitBuild\Debug_Cairo_CFLite\lib\JavaScriptCore_debug.lib and object D:\Projects\BuildSlave\win-cairo-debug\build\WebKitBuild\Debug_Cairo_CFLite\lib\JavaScriptCore_debug.exp 2>ExceptionHelpers.obj : error LNK2019: unresolved external symbol "private: void * __thiscall JSC::Heap::allocateSlowCase(unsigned int)" (?allocateSlowCase@Heap@JSC@@AAEPAXI@Z) referenced in function "public: void * __thiscall JSC::Heap::allocate(unsigned int)" (?allocate@Heap@JSC@@QAEPAXI@Z) 2>NativeErrorConstructor.obj : error LNK2001: unresolved external symbol "private: void * __thiscall JSC::Heap::allocateSlowCase(unsigned int)" (?allocateSlowCase@Heap@JSC@@AAEPAXI@Z) 2>RegExpConstructor.obj : error LNK2001: unresolved external symbol "private: void * __thiscall JSC::Heap::allocateSlowCase(unsigned int)" (?allocateSlowCase@Heap@JSC@@AAEPAXI@Z) 2>JITArithmetic32_64.obj : error LNK2001: unresolved external symbol "private: void * __thiscall JSC::Heap::allocateSlowCase(unsigned int)" (?allocateSlowCase@Heap@JSC@@AAEPAXI@Z) 2>ExceptionHelpers.obj : error LNK2019: unresolved external symbol "private: void * __thiscall JSC::MarkedSpace::allocateFromSizeClass(struct JSC::MarkedSpace::SizeClass &)" (?allocateFromSizeClass@MarkedSpace@JSC@@AAEPAXAAUSizeClass@12@@Z) referenced in function "public: void * __thiscall JSC::MarkedSpace::allocate(unsigned int)" (?allocate@MarkedSpace@JSC@@QAEPAXI@Z) 2>NativeErrorConstructor.obj : error LNK2001: unresolved external symbol "private: void * __thiscall JSC::MarkedSpace::allocateFromSizeClass(struct JSC::MarkedSpace::SizeClass &)" (?allocateFromSizeClass@MarkedSpace@JSC@@AAEPAXAAUSizeClass@12@@Z) 2>RegExpConstructor.obj : error LNK2001: unresolved external symbol "private: void * __thiscall JSC::MarkedSpace::allocateFromSizeClass(struct JSC::MarkedSpace::SizeClass &)" (?allocateFromSizeClass@MarkedSpace@JSC@@AAEPAXAAUSizeClass@12@@Z) 2>JITArithmetic32_64.obj : error LNK2001: unresolved external symbol "private: void * __thiscall JSC::MarkedSpace::allocateFromSizeClass(struct JSC::MarkedSpace::SizeClass &)" (?allocateFromSizeClass@MarkedSpace@JSC@@AAEPAXAAUSizeClass@12@@Z) 2>D:\Projects\BuildSlave\win-cairo-debug\build\WebKitBuild\Debug_Cairo_CFLite\bin\JavaScriptCore_debug.dll : fatal error LNK1120: 2 unresolved externals 2>Build log was saved at "file://D:\Projects\BuildSlave\win-cairo-debug\build\WebKitBuild\Debug_Cairo_CFLite\obj\JavaScriptCore\BuildLog.htm" 2>JavaScriptCore - 9 error(s), 0 warning(s) 3>------ Build started: Project: WebCoreGenerated, Configuration: Debug_Cairo_CFLite Win32 ------ Do we need to touch a property file to force a rebuild?

Note You need to log in before you can comment on or make changes to this bug.