Bug 61690

Summary: [GTK] Remove PasteboardHelperGtk
Product: WebKit Reporter: Martin Robinson <mrobinson>
Component: WebKitGTKAssignee: Martin Robinson <mrobinson>
Status: RESOLVED FIXED    
Severity: Normal CC: gustavo, xan.lopez
Priority: P3 Keywords: Gtk
Version: 528+ (Nightly build)   
Hardware: PC   
OS: Linux   
Bug Depends on:    
Bug Blocks: 61734    
Attachments:
Description Flags
Patch none

Description Martin Robinson 2011-05-28 12:48:46 PDT
PasteboardHelperGtk is an implementation of an abstract class, PasteboardHelper, that allows the GtkClipboard IDs to be defined in WebKit and used in WebCore. Instead of this convoluted approach, it would be better to simply use the default WebCore values and assert that they are equal in WebKit. The pattern is already in use -- see WebCoreSupport/AssertMatchingEnums.cpp.
Comment 1 Martin Robinson 2011-05-28 13:43:26 PDT
Created attachment 95272 [details]
Patch
Comment 2 Gustavo Noronha (kov) 2011-06-02 16:15:38 PDT
Comment on attachment 95272 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=95272&action=review

yay; need to go through this simplification drill on the fullscreen video stuff sometime

> Source/WebCore/ChangeLog:5
> +        [GTK] Remove PastboardHelperGtk

missing e on Paste

> Source/WebCore/ChangeLog:15
> +        * platform/Pasteboard.h: Remove GTK+ specific methods. They are no longer needed.j

trailing j

> Source/WebCore/platform/gtk/PasteboardGtk.cpp:59
> +    PasteboardHelper* defaultHelper = PasteboardHelper::defaultPasteboardHelper();

just a suggestion, I'd use helper here instead of defaultHelper for the variable name; 'default' doesn't really add much information
Comment 3 Martin Robinson 2011-06-02 18:05:46 PDT
(In reply to comment #2)
> (From update of attachment 95272 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=95272&action=review
> 
> yay; need to go through this simplification drill on the fullscreen video stuff sometime

Thanks for the review!

> > Source/WebCore/ChangeLog:5
> > +        [GTK] Remove PastboardHelperGtk
> missing e on Paste

Oops! Fixed.

> > Source/WebCore/ChangeLog:15
> > +        * platform/Pasteboard.h: Remove GTK+ specific methods. They are no longer needed.j
> 
> trailing j

Fixed.

> > Source/WebCore/platform/gtk/PasteboardGtk.cpp:59
> > +    PasteboardHelper* defaultHelper = PasteboardHelper::defaultPasteboardHelper();
> just a suggestion, I'd use helper here instead of defaultHelper for the variable name; 'default' doesn't really add much information

Made this change across the entire file.
Comment 4 Martin Robinson 2011-06-02 18:06:10 PDT
Committed r87978: <http://trac.webkit.org/changeset/87978>