Bug 61682 – Convert editing/pasteboard/paste-blockquote-into-blockquote-2.html to dump-as-markup

• Component: HTML Editing
• Status: RESOLVED FIXED

[Annie Sullivan]

The test output would be much easier to read as dump-as-markup.

[Annie Sullivan]

Created attachment 95250 [details]
Patch

[Ryosuke Niwa]

Comment on attachment 95250 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=95250&action=review

> LayoutTests/editing/pasteboard/paste-blockquote-into-blockquote-2-expected.txt:1
> +This tests pasting a nested blockquote into a blockquote. The first line below should be singly-blockquoted, and the second should be doubly-blockquoted.

I'd rather explicitly say that "One" should be singly-blockquoted and "Two" and "Three" should be doubly-blockquoted.  And it seems like there's a bug here.  Two is somehow singly-blockquoted.  Please file a bug and make it depend on this bug.

[Annie Sullivan]

Comment on attachment 95250 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=95250&action=review

>> LayoutTests/editing/pasteboard/paste-blockquote-into-blockquote-2-expected.txt:1
>> +This tests pasting a nested blockquote into a blockquote. The first line below should be singly-blockquoted, and the second should be doubly-blockquoted.
> 
> I'd rather explicitly say that "One" should be singly-blockquoted and "Two" and "Three" should be doubly-blockquoted.  And it seems like there's a bug here.  Two is somehow singly-blockquoted.  Please file a bug and make it depend on this bug.

Bug filed. Looks like this behavior has been there since the test was created.

I'll update the description to clarify what the behavior is, and mention the bug.

[Annie Sullivan]

Created attachment 95486 [details]
Patch

[Ryosuke Niwa]

Comment on attachment 95486 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=95486&action=review

> LayoutTests/editing/pasteboard/paste-blockquote-into-blockquote-2-expected.txt:1
> +This tests pasting a nested blockquote into a blockquote. The text "One" should be singly-blockquoted, and the text "Two Three" should be doubly-blockquoted. However, currently "One Two" is singly blockquoted and "Three" is doubly-blockquoted. See bug 61807.

You probably want to put "-" between singly and blockquoted.

> LayoutTests/editing/pasteboard/paste-blockquote-into-blockquote-2.html:26
> +Markup.description("This tests pasting a nested blockquote into a blockquote. " +
> +                   "The text \"One\" should be singly-blockquoted, and the text \"Two Three\" should be doubly-blockquoted. " +
> +                   "However, currently \"One Two\" is singly blockquoted and \"Three\" is doubly-blockquoted. See bug 61807.");

We don't normally indent text like this.  Please just indent 4 spaces on the second and the third line.  Also + should be on the next line not on the previous line (the indentation should be before +).

[Annie Sullivan]

Created attachment 95488 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 95488 [details]
Patch

Clearing flags on attachment: 95488

Committed r87775: <http://trac.webkit.org/changeset/87775>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.