| Summary: | New bug links on TestFailures page often contain titles that are so long they are rejected by Bugzilla | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Adam Roben (:aroben) <aroben> | ||||
| Component: | Tools / Tests | Assignee: | Nobody <webkit-unassigned> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | ddkilzer | ||||
| Priority: | P2 | ||||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | All | ||||||
| OS: | All | ||||||
| URL: | http://build.webkit.org/TestFailures | ||||||
| Attachments: |
|
||||||
Created attachment 98363 [details]
Make finding existing bugs and filing new bugs work on TestFailures even when lots of tests are failing
Comment on attachment 98363 [details] Make finding existing bugs and filing new bugs work on TestFailures even when lots of tests are failing View in context: https://bugs.webkit.org/attachment.cgi?id=98363&action=review r=me > Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js:272 > + title = titlePrefix + failingTests.length + ' tests' + titleSuffix; Would be nice to have some kind of ASSERT(title.length < Bugzilla.maximumBugTitleLength). Comment on attachment 98363 [details] Make finding existing bugs and filing new bugs work on TestFailures even when lots of tests are failing View in context: https://bugs.webkit.org/attachment.cgi?id=98363&action=review >> Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js:272 >> + title = titlePrefix + failingTests.length + ' tests' + titleSuffix; > > Would be nice to have some kind of ASSERT(title.length < Bugzilla.maximumBugTitleLength). I'll add a console.assert that does just that. Committed r89588: <http://trac.webkit.org/changeset/89588> |
Bugzilla apparently has a 255-character limit on bug titles. The TestFailures page's new bug links include the names of all the failing tests, which can often be much more than 255 characters. Trying to submit one of these bugs results in an obscure Bugzilla error like this: DBD::Pg::db selectrow_array failed: ERROR: current transaction is aborted, commands ignored until end of transaction block [for Statement "SELECT CURRVAL('bugs_bug_id_seq')"] at Bugzilla/DB/Pg.pm line 90 Bugzilla::DB::Pg::bz_last_key('Bugzilla::DB::Pg=HASH(0x100ebfdd8)', 'bugs', 'bug_id') called at Bugzilla/Object.pm line 367 Bugzilla::Object::insert_create_data('Bugzilla::Bug', 'HASH(0x10096bf98)') called at Bugzilla/Bug.pm line 352 Bugzilla::Bug::create('Bugzilla::Bug', 'HASH(0x100e244c0)') called at /www/hosts/bugs.webkit.org/post_bug.cgi line 177 We should make the TestFailures page never create a bug title that's longer than 255 characters.