Bug 61647

Summary: Entering full-screen with document.documentElement does not animate.
Product: WebKit Reporter: Jer Noble <jer.noble>
Component: WebKit2Assignee: Jer Noble <jer.noble>
Status: RESOLVED WONTFIX    
Severity: Normal CC: aestes, eric.carlson, eric, simon.fraser
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Description Jer Noble 2011-05-27 10:45:25 PDT 
Entering full-screen with document.documentElement does not animate.
Comment 1 Jer Noble 2011-05-27 10:45:39 PDT 
<rdar://problem/9515898>
Comment 2 Jer Noble 2011-05-27 11:17:16 PDT 
Created attachment 95196 [details]
Patch
Comment 3 Andy Estes 2011-06-14 13:46:24 PDT 
Comment on attachment 95196 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=95196&action=review

> Source/WebKit2/ChangeLog:17
> +        (WebKit::WebFullScreenManagerMac::finishedNullEnterAnimation): Added.
> +        (WebKit::WebFullScreenManagerMac::finishedNullExitAnimation): Added.

I'm having a hard time with 'Null' in this method name. If I read the method name without looking at the context I would assume that the animation would be a no-op due to the term 'null'.

> Source/WebKit2/ChangeLog:41
> +2011-05-27  Jer Noble  <jer.noble@apple.com>
> +
> +        Reviewed by NOBODY (OOPS!).
> +
> +        Entering full-screen with document.documentElement does not animate.
> +        https://bugs.webkit.org/show_bug.cgi?id=61647
> +
> +        * WebProcess/FullScreen/mac/WebFullScreenManagerMac.h:
> +        * WebProcess/FullScreen/mac/WebFullScreenManagerMac.mm:
> +        (WebKit::WebFullScreenManagerMac::WebFullScreenManagerMac):
> +        (WebKit::WebFullScreenManagerMac::finishedNullEnterAnimation):
> +        (WebKit::WebFullScreenManagerMac::finishedNullExitAnimation):
> +        (WebKit::WebFullScreenManagerMac::beginEnterFullScreenAnimation):
> +        (WebKit::WebFullScreenManagerMac::beginExitFullScreenAnimation):
> +

This should be removed.
Comment 4 Eric Seidel (no email) 2012-01-30 15:22:06 PST 
Looks like this was forgotten?
Comment 5 Eric Seidel (no email) 2012-03-01 15:05:27 PST 
Still forgotten?  Should this be closed?
Comment 6 Jer Noble 2012-03-14 13:23:08 PDT 
This was fixed by bug #78930.
Comment 7 Eric Seidel (no email) 2012-03-20 00:44:40 PDT 
Comment on attachment 95196 [details]
Patch

Cleared review? from attachment 95196 [details] so that this bug does not appear in http://webkit.org/pending-review.  If you would like this patch reviewed, please attach it to a new bug (or re-open this bug before marking it for review again).