Bug 6161

Summary:

REGRESSION: crash when pressing tab in editable WebHTMLView

Product:

WebKit

Reporter:

Alexey Proskuryakov <ap>

Component:

HTML Editing

Assignee:

Darin Adler <darin>

Status:

CLOSED FIXED

Severity:

Critical

Priority:

Version:

420+

Hardware:

Mac

OS:

OS X 10.4

Attachments:

Description	Flags
full crash log	none

Alexey Proskuryakov

Reported 2005-12-20 03:56:08 PST

Pressing Tab in Blot (or other editable html views) causes a crash. At a first glance, looks like a regression from a fix in bug 6143 (DOM::ElementImpl should use a RefPtr for the attribute map). First few lines of crash log: Thread 0 Crashed: 0 <<00000000>> 0x00a073a4 0 + 10515364 1 com.apple.WebCore 0x01898360 DOM::ElementImpl::setAttribute(DOM::QualifiedName const&, DOM::DOMStringImpl*, int&) + 104 (dom_elementimpl.cpp:381) 2 com.apple.WebCore 0x018985ac DOM::ElementImpl::setAttribute(DOM::QualifiedName const&, DOM::DOMString const&) + 72 (dom_elementimpl.cpp:305) 3 com.apple.WebCore 0x01919510 khtml::createTabSpanElement(DOM::DocumentImpl*, DOM::NodeImpl*) + 316 (htmlediting.cpp:353) 4 com.apple.WebCore 0x0198f2d0 khtml::InsertTextCommand::insertTab(DOM::Position) + 304 (insert_text_command.cpp:176) 5 com.apple.WebCore 0x0198fb2c khtml::InsertTextCommand::input(DOM::DOMString const&, bool) + 764 (insert_text_command.cpp:127)

Attachments
full crash log (18.12 KB, text/plain) 2005-12-20 03:57 PST, Alexey Proskuryakov	no flags	Details
View All Add attachment proposed patch, testcase, etc.

Alexey Proskuryakov

Comment 1 2005-12-20 03:57:28 PST

Created attachment 5175 [details] full crash log

Justin Garcia

Comment 2 2005-12-20 13:18:06 PST

Backed out the use of a RefPtr for the element inside addAttribute.

Note You need to log in before you can comment on or make changes to this bug.