Bug 61597

Summary:

editing/pasteboard/5089327.html should be renamed and converted to a dump-as-markup test

Product:

WebKit

Reporter:

Ryosuke Niwa <rniwa>

Component:

Tools / Tests

Assignee:

Ryosuke Niwa <rniwa>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

ap, eric, morrita, tkent

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

34564

Attachments:

Description	Flags
61597	none

Description Ryosuke Niwa 2011-05-26 19:56:27 PDT

We should give editing/pasteboard/4700297.html a more descriptive name and convert it to a dump-as-markup test.

Comment 1 Ryosuke Niwa 2011-05-26 20:09:33 PDT

Created attachment 95100 [details]
61597

Comment 2 Eric Seidel (no email) 2011-05-26 20:23:06 PDT

Comment on attachment 95100 [details]
61597

OK.

Comment 3 Ryosuke Niwa 2011-05-26 20:27:14 PDT

Comment on attachment 95100 [details]
61597

Thanks for the reviews!

Comment 4 Ryosuke Niwa 2011-05-26 22:30:01 PDT

Comment on attachment 95100 [details]
61597

Clearing flags on attachment: 95100

Committed r87470: <http://trac.webkit.org/changeset/87470>

Comment 5 Ryosuke Niwa 2011-05-26 22:30:06 PDT

All reviewed patches have been landed.  Closing bug.

Comment 6 Alexey Proskuryakov 2011-05-27 17:08:03 PDT

I don't see anything blue in this test's new expected result :-)

+This tests to make sure that content that has the document default color is pasted as blue
+(or whatever the color for quoted content is) when pasted in the middle of quoted content.
+| <blockquote>
+|   type="cite"
+|   <div>
+|     "("
+|     "This text should be blue.<#selection-caret>"
+|     ")"

Comment 7 Ryosuke Niwa 2011-05-27 17:10:50 PDT

(In reply to comment #6)
> I don't see anything blue in this test's new expected result :-)
> 
> +This tests to make sure that content that has the document default color is pasted as blue
> +(or whatever the color for quoted content is) when pasted in the middle of quoted content.
> +| <blockquote>
> +|   type="cite"
> +|   <div>
> +|     "("
> +|     "This text should be blue.<#selection-caret>"
> +|     ")"

Yeah, I thought about this for a while but "whatever the color for quoted content is" seems to clarify this point.  I'm more than happy to change if you come up with a better description.