Bug 61578 – HTMLVideoElement::currentSrc() should return a KURL

• Component: New Bugs
• Status: RESOLVED FIXED

[WebKit Review Bot]

HTMLVideoElement::currentSrc() should return a KURL
Requested by abarth on #webkit.

[Adam Barth]

Created attachment 95132 [details]
Patch

[Alexis Menard (darktears)]

Comment on attachment 95132 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=95132&action=review

> Source/WebCore/html/canvas/CanvasRenderingContext.cpp:75
> +    // HTMLMediaElement.currentSrc DOM API would leak redirect detinations!

Typo here.

> Source/WebCore/rendering/HitTestResult.cpp:315
> +        return mediaElt->currentSrc();

I believe this is the same code because currentSrc has already his baseURL set.

[Eric Seidel (no email)]

Comment on attachment 95132 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=95132&action=review

> Source/WebCore/html/HTMLMediaElement.cpp:678
> +    LOG(Media, "HTMLMediaElement::loadResource(%s, %s)", urlForLogging(initialURL).utf8().data(), contentType.raw().utf8().data());

Ha.  Seems urlForLogging should return a char*...

>> Source/WebCore/rendering/HitTestResult.cpp:315
>> +        return mediaElt->currentSrc();
> 
> I believe this is the same code because currentSrc has already his baseURL set.

Is this tested anywhere?  How do I as a reviewer know it's already absolute. :)

[Adam Barth]

(In reply to comment #3)
> (From update of attachment 95132 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=95132&action=review
> 
> > Source/WebCore/html/HTMLMediaElement.cpp:678
> > +    LOG(Media, "HTMLMediaElement::loadResource(%s, %s)", urlForLogging(initialURL).utf8().data(), contentType.raw().utf8().data());
> 
> Ha.  Seems urlForLogging should return a char*...

Very true.

> >> Source/WebCore/rendering/HitTestResult.cpp:315
> >> +        return mediaElt->currentSrc();
> > 
> > I believe this is the same code because currentSrc has already his baseURL set.
> 
> Is this tested anywhere?  How do I as a reviewer know it's already absolute. :)

I'm not sure whether this is tested, but AFAIK the KURL type only holds absolute URLs, so the C++ type system (such as it is) can tell you that.  :)

[Adam Barth]

Created attachment 95190 [details]
Patch for landing

[WebKit Commit Bot]

Comment on attachment 95190 [details]
Patch for landing

Clearing flags on attachment: 95190

Committed r87539: <http://trac.webkit.org/changeset/87539>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.