Overload resolution in generated JSC bindings could be more efficient.

• Component: WebCore JavaScript
• Status: RESOLVED FIXED

[Andreas Kling]

The overload resolution code generated by CodeGeneratorJS.pm currently looks like this:

EncodedJSValue JSC_HOST_CALL jsWebGLRenderingContextPrototypeFunctionBufferSubData(ExecState* exec)
{
    if ((exec->argumentCount() == 3 && (exec->argument(2).isNull() || (exec->argument(2).isObject() && asObject(exec->argument(2))->inherits(&JSArrayBuffer::s_info)))))
        return jsWebGLRenderingContextPrototypeFunctionBufferSubData1(exec);
    if ((exec->argumentCount() == 3 && (exec->argument(2).isNull() || (exec->argument(2).isObject() && asObject(exec->argument(2))->inherits(&JSArrayBufferView::s_info)))))
        return jsWebGLRenderingContextPrototypeFunctionBufferSubData2(exec);
    return throwVMTypeError(exec);
}

This could be a lot more efficient (no need for all those calls to argumentCount() and argument().)

[Andreas Kling]

Created attachment 95006 [details]
Proposed patch

[Andreas Kling]

For reference, same function after this patch:

EncodedJSValue JSC_HOST_CALL jsWebGLRenderingContextPrototypeFunctionBufferSubData(ExecState* exec)
{
    size_t argsCount = exec->argumentCount();
    JSValue arg2(exec->argument(2));
    if ((argsCount == 3 && (arg2.isNull() || (arg2.isObject() && asObject(arg2)->inherits(&JSArrayBuffer::s_info)))))
        return jsWebGLRenderingContextPrototypeFunctionBufferSubData1(exec);
    if ((argsCount == 3 && (arg2.isNull() || (arg2.isObject() && asObject(arg2)->inherits(&JSArrayBufferView::s_info)))))
        return jsWebGLRenderingContextPrototypeFunctionBufferSubData2(exec);
    return throwVMTypeError(exec);
}

[Geoffrey Garen]

Comment on attachment 95006 [details]
Proposed patch

r=me

[Andreas Kling]

Comment on attachment 95006 [details]
Proposed patch

Clearing flags on attachment: 95006

Committed r87412: <http://trac.webkit.org/changeset/87412>

[Andreas Kling]

All reviewed patches have been landed.  Closing bug.