Summary: | Switch positionOverflowControls to IntPoint | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Levi Weintraub <leviw> | ||||||
Component: | Layout and Rendering | Assignee: | Levi Weintraub <leviw> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | darin, eae, eric, simon.fraser | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Bug Depends on: | |||||||||
Bug Blocks: | 60318 | ||||||||
Attachments: |
|
Description
Levi Weintraub
2011-05-25 18:08:07 PDT
Created attachment 94908 [details]
Patch
Comment on attachment 94908 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=94908&action=review > Source/WebCore/rendering/RenderLayer.cpp:2030 > + IntRect absBounds(borderBox.x() + offsetFromLayer.x(), borderBox.y() + offsetFromLayer.y(), borderBox.width(), borderBox.height()); And here... :) Definitely a size. (I've yet to see the true appeal of the size vs. point dichotomy. Mostly it's just a pain to work with.) > Source/WebCore/rendering/RenderLayer.cpp:2046 > + layer->setPosition(IntPoint(m_hBar->frameRect().x() - offsetFromLayer.y(), m_hBar->frameRect().y() - offsetFromLayer.y())); Seems this wants to be a size, cause then you would just do point math there. > Source/WebCore/rendering/RenderLayer.cpp:2053 > + layer->setPosition(IntPoint(m_vBar->frameRect().x() - offsetFromLayer.x(), m_vBar->frameRect().y() - offsetFromLayer.y())); And here. Created attachment 95031 [details]
Patch
Comment on attachment 95031 [details]
Patch
LGTM.
Comment on attachment 95031 [details] Patch Clearing flags on attachment: 95031 Committed r87437: <http://trac.webkit.org/changeset/87437> All reviewed patches have been landed. Closing bug. |