Bug 61481

Summary: CachedResource overhead size calculation ignores the actual size of the URL
Product: WebKit Reporter: James Robinson <jamesr>
Component: New BugsAssignee: James Robinson <jamesr>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, dglazkov, gustavo.noronha, gustavo, japhet, koivisto, webkit.review.bot, xan.lopez
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch ggaren: review+, webkit-ews: commit-queue-

Description James Robinson 2011-05-25 16:16:16 PDT 
CachedResource overhead size calculation ignores the actual size of the URL
Comment 1 James Robinson 2011-05-25 16:19:18 PDT 
Created attachment 94878 [details]
Patch
Comment 2 James Robinson 2011-05-25 16:20:23 PDT 
This is one issue that contributes to the memory growth seen on the test page from https://bugs.webkit.org/show_bug.cgi?id=61006.
Comment 3 Geoffrey Garen 2011-05-25 16:20:45 PDT 
Comment on attachment 94878 [details]
Patch

r=me
Comment 4 Early Warning System Bot 2011-05-25 16:33:51 PDT 
Comment on attachment 94878 [details]
Patch

Attachment 94878 [details] did not pass qt-ews (qt):
Output: http://queues.webkit.org/results/8731864
Comment 5 WebKit Commit Bot 2011-05-25 17:37:17 PDT 
Comment on attachment 94878 [details]
Patch

Attachment 94878 [details] did not pass mac-ews (mac):
Output: http://queues.webkit.org/results/8736095
Comment 6 Collabora GTK+ EWS bot 2011-05-25 17:46:01 PDT 
Comment on attachment 94878 [details]
Patch

Attachment 94878 [details] did not pass gtk-ews (gtk):
Output: http://queues.webkit.org/results/8737021
Comment 7 James Robinson 2011-05-25 17:49:33 PDT 
This collides a bit with http://trac.webkit.org/changeset/87239, hence all the EWS sadness.  Will resolve before landing (the difference is that the request url now lives on m_resourceRequest instead of being a string hanging directly off the CachedResource).
Comment 8 James Robinson 2011-05-25 18:08:09 PDT 
Committed r87344: <http://trac.webkit.org/changeset/87344>