| Summary: | TestFailures page doesn't show testers with only a single failing test | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Adam Roben (:aroben) <aroben> | ||||
| Component: | Tools / Tests | Assignee: | Adam Roben (:aroben) <aroben> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | ddkilzer, joepeck | ||||
| Priority: | P2 | ||||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | All | ||||||
| OS: | All | ||||||
| URL: | http://build.webkit.org/TestFailures | ||||||
| Attachments: |
|
||||||
|
Description
Adam Roben (:aroben)
2011-05-25 13:19:15 PDT
Created attachment 94847 [details]
Correctly detect cases where only a single test failed/crashed/timed out
Comment on attachment 94847 [details] Correctly detect cases where only a single test failed/crashed/timed out View in context: https://bugs.webkit.org/attachment.cgi?id=94847&action=review > Tools/ChangeLog:16 > + * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js: > + (ViewController.prototype._displayTesters): Only pluralize "test" when more than one test > + failed/crashed/timed out. Is this part of the bug fix, or just a related tweak? Comment on attachment 94847 [details] Correctly detect cases where only a single test failed/crashed/timed out View in context: https://bugs.webkit.org/attachment.cgi?id=94847&action=review >> Tools/ChangeLog:16 >> + failed/crashed/timed out. > > Is this part of the bug fix, or just a related tweak? Just a related tweak. Before this patch we'd never display fewer than 2 failures here, so we never need to have the singular "test" instead of the plural "tests". Committed r87378: <http://trac.webkit.org/changeset/87378> |