Bug 6139

Summary: ATSUI code path should implement small caps, synthetic bold and oblique and correct metrics for fallback fonts
Product: WebKit Reporter: mitz
Component: Layout and RenderingAssignee: Nobody <webkit-unassigned>
Status: VERIFIED FIXED    
Severity: Normal    
Priority: P2    
Version: 420+   
Hardware: Mac   
OS: OS X 10.4   
Bug Depends on:    
Bug Blocks: 5166    
Attachments:
Description Flags
Patch (incl. layout test) darin: review+

mitz
Reported 2005-12-18 12:34:23 PST
[Split off from bug 5166] Add the following missing features to the ATSUI code path in WebTextRenderer: * small caps * synthetic bold * synthetic oblique When a fallback font is used, compute metrics according to the fallback's rendering mode, to be consistent with the CG code path.
Attachments
Patch (incl. layout test) (30.63 KB, patch)
2005-12-18 14:08 PST, mitz 		darin: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
mitz
Comment 1 2005-12-18 14:08:08 PST
Created attachment 5140 [details] Patch (incl. layout test)
mitz
Comment 2 2005-12-18 14:18:30 PST
Comment on attachment 5140 [details] Patch (incl. layout test) The code changes in this patch combine attachment 4966 [details] and attachment 4968 [details], changing several YES/NO to true/false and adding + if (!u_isbase(c)) + renderers[i] = isSmallCap ? getSmallCapsRenderer(r) : r; to make sure that combining marks stay in the same renderer as the base character preceding them.
Darin Adler
Comment 3 2005-12-18 14:33:07 PST
Comment on attachment 5140 [details] Patch (incl. layout test) r=me
Note You need to log in before you can comment on or make changes to this bug.