Bug 6138

Summary:

QString should be sent to pasture and replaced by DOMString/DOMStringImpl

Product:

WebKit

Reporter:

Eric Seidel (no email) <eric>

Component:

WebKit Misc.

Assignee:

Eric Seidel (no email) <eric>

Status:

RESOLVED FIXED

Severity:

Normal

Priority:

Version:

420+

Hardware:

Mac

OS:

OS X 10.4

Attachments:

Description	Flags
first patch, removing many uses of .qstring()	mjs: review+

Eric Seidel (no email)

Reported 2005-12-18 10:55:38 PST

QString should be sent to pasture and replaced by DOMString/DOMStringImpl I'm about 50% of the way through this in WebCore. I'm going to attach the patches in pieces as I get things back up and running.

Attachments
first patch, removing many uses of .qstring() (92.77 KB, patch) 2005-12-22 19:50 PST, Eric Seidel (no email)	mjs: review+	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Eric Seidel (no email)

Comment 1 2005-12-22 19:50:37 PST

Created attachment 5234 [details] first patch, removing many uses of .qstring()

Eric Seidel (no email)

Comment 2 2005-12-22 20:02:24 PST

Comment on attachment 5234 [details] first patch, removing many uses of .qstring() removes KWQLabel (unused) converts a bunch of QString to DOMString adds DOMString::replace(QChar,QChar) removes a bunch of .qstring() usage.

Maciej Stachowiak

Comment 3 2005-12-22 22:57:17 PST

Comment on attachment 5234 [details] first patch, removing many uses of .qstring() r=me assuming no performance regression and that layout tests pass.

Note You need to log in before you can comment on or make changes to this bug.