Bug 61364

Summary: Web Inspector: inspected page crashes when call stack is empty after live edit.
Product: WebKit Reporter: Pavel Podivilov <podivilov>
Component: Web Inspector (Deprecated)Assignee: Pavel Podivilov <podivilov>
Status: RESOLVED FIXED    
Severity: Normal CC: apavlov, bweinstein, joepeck, keishi, loislo, pfeldman, pmuellr, rik, timothy, yurys
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch. yurys: review+

Description Pavel Podivilov 2011-05-24 08:29:12 PDT
Web Inspector: inspected page crashes when call stack is empty after live edit.
Comment 1 Pavel Podivilov 2011-05-24 08:29:46 PDT
Created attachment 94614 [details]
Patch.
Comment 2 Yury Semikhatsky 2011-05-24 09:08:06 PDT
Comment on attachment 94614 [details]
Patch.

View in context: https://bugs.webkit.org/attachment.cgi?id=94614&action=review

> Source/WebCore/bindings/v8/ScriptDebugServer.cpp:252
> +    if (currentCallFrameV8->IsObject())

Prefer early return.
Comment 3 Yury Semikhatsky 2011-05-24 09:08:29 PDT
Can we have a test for this case?
Comment 4 Pavel Podivilov 2011-05-25 02:03:36 PDT
Committed r87280: <http://trac.webkit.org/changeset/87280>