Bug 61357

Summary:

JSAudioContextCustom doesn't encode errors

Product:

WebKit

Reporter:

Philippe Normand <pnormand>

Component:

JavaScriptCore

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

kling

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

61355

Attachments:

Description	Flags
Fix AudioContext return values	kling: review-
Fix AudioContext return values	kling: review+

Philippe Normand

Reported 2011-05-24 04:16:40 PDT

patch incoming about this

Attachments
Fix AudioContext return values (3.69 KB, patch) 2011-05-24 04:17 PDT, Philippe Normand	kling: review-	Details Formatted Diff Diff
Fix AudioContext return values (3.61 KB, patch) 2011-05-24 10:05 PDT, Philippe Normand	kling: review+	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Philippe Normand

Comment 1 2011-05-24 04:17:59 PDT

Created attachment 94593 [details] Fix AudioContext return values

Andreas Kling

Comment 2 2011-05-24 06:12:30 PDT

Comment on attachment 94593 [details] Fix AudioContext return values Nice catch, but you should change the throwError() calls to throwVMError() instead.

Philippe Normand

Comment 3 2011-05-24 10:05:06 PDT

Created attachment 94632 [details] Fix AudioContext return values

Andreas Kling

Comment 4 2011-05-24 10:09:11 PDT

Comment on attachment 94632 [details] Fix AudioContext return values r=me

Philippe Normand

Comment 5 2011-05-24 10:12:54 PDT

Committed r87163: <http://trac.webkit.org/changeset/87163>

Note You need to log in before you can comment on or make changes to this bug.