| Summary: | Refactor RenderView::{enable,disable}LayoutState call sites to use RIIA | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Yuzo Fujishima <yuzo> | ||||||
| Component: | Layout and Rendering | Assignee: | Yuzo Fujishima <yuzo> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | commit-queue | ||||||
| Priority: | P2 | ||||||||
| Version: | 528+ (Nightly build) | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Bug Depends on: | |||||||||
| Bug Blocks: | 47815 | ||||||||
| Attachments: |
|
||||||||
Created attachment 94588 [details]
Patch
Comment on attachment 94588 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=94588&action=review looks good. > Source/WebCore/page/FrameView.cpp:987 > + if (subtree) { > + RenderView* view = root->view(); > + view->popLayoutState(root); > + } nit: The variable 'view' is not needed. if (subtree) root->view()->popLayoutState(root); Created attachment 94733 [details]
Addressed nit
Comment on attachment 94733 [details] Addressed nit Clearing flags on attachment: 94733 Committed r87277: <http://trac.webkit.org/changeset/87277> All reviewed patches have been landed. Closing bug. |
The following pattern appears 10 times or so in the codebase. view->disableLayoutState(); ... view->enableLayoutState(); It should be replaced with RIIA, that is: { LayoutStateDisabler layoutStateDisabler(view); ... }