Bug 61351

Summary: Use Element::shadowPseudoId() for text field decoration elements
Product: WebKit Reporter: Kent Tamura <tkent>
Component: DOMAssignee: Kent Tamura <tkent>
Status: RESOLVED FIXED    
Severity: Normal CC: dglazkov, morrita
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 61166    
Attachments:
Description Flags
Patch none

Kent Tamura
Reported 2011-05-24 02:32:11 PDT
Use Element::shodowPseudoId() for text field decoration elements
Attachments
Patch (22.34 KB, patch)
2011-05-24 02:45 PDT, Kent Tamura 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Kent Tamura
Comment 1 2011-05-24 02:45:23 PDT
Created attachment 94587 [details] Patch
Kent Tamura
Comment 2 2011-05-24 02:47:18 PDT
Comment on attachment 94587 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=94587&action=review > Source/WebCore/html/shadow/TextControlInnerElements.cpp:129 > + Node* host = const_cast<SearchFieldResultsButtonElement*>(this)->shadowAncestorNode(); Unfortunately const_cast<> is required. Too bad.
Dimitri Glazkov (Google)
Comment 3 2011-05-24 08:08:20 PDT
Comment on attachment 94587 [details] Patch lovely.
Dimitri Glazkov (Google)
Comment 4 2011-05-24 08:23:44 PDT
Comment on attachment 94587 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=94587&action=review > Source/WebCore/ChangeLog:5 > + Use Element::shodowPseudoId() for text field decoration elements Misspelled changelog!!
Dimitri Glazkov (Google)
Comment 5 2011-05-24 08:24:09 PDT
Sorry, didn't want this to land and forever be misspelled in the history of WebKit :)
Kent Tamura
Comment 6 2011-05-24 08:26:54 PDT
shodow!!
Kent Tamura
Comment 7 2011-05-24 17:18:49 PDT
Committed r87235: <http://trac.webkit.org/changeset/87235>
Kent Tamura
Comment 8 2011-05-24 17:19:55 PDT
Comment on attachment 94587 [details] Patch Landed with a typo fix and const_cast removal.
Note You need to log in before you can comment on or make changes to this bug.