Bug 61351

Summary: Use Element::shadowPseudoId() for text field decoration elements
Product: WebKit Reporter: Kent Tamura <tkent>
Component: DOMAssignee: Kent Tamura <tkent>
Status: RESOLVED FIXED    
Severity: Normal CC: dglazkov, morrita
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 61166    
Attachments:
Description Flags
Patch none

Description Kent Tamura 2011-05-24 02:32:11 PDT
Use Element::shodowPseudoId() for text field decoration elements
Comment 1 Kent Tamura 2011-05-24 02:45:23 PDT
Created attachment 94587 [details]
Patch
Comment 2 Kent Tamura 2011-05-24 02:47:18 PDT
Comment on attachment 94587 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=94587&action=review

> Source/WebCore/html/shadow/TextControlInnerElements.cpp:129
> +    Node* host = const_cast<SearchFieldResultsButtonElement*>(this)->shadowAncestorNode();

Unfortunately const_cast<> is required.  Too bad.
Comment 3 Dimitri Glazkov (Google) 2011-05-24 08:08:20 PDT
Comment on attachment 94587 [details]
Patch

lovely.
Comment 4 Dimitri Glazkov (Google) 2011-05-24 08:23:44 PDT
Comment on attachment 94587 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=94587&action=review

> Source/WebCore/ChangeLog:5
> +        Use Element::shodowPseudoId() for text field decoration elements

Misspelled changelog!!
Comment 5 Dimitri Glazkov (Google) 2011-05-24 08:24:09 PDT
Sorry, didn't want this to land and forever be misspelled in the history of WebKit :)
Comment 6 Kent Tamura 2011-05-24 08:26:54 PDT
shodow!!
Comment 7 Kent Tamura 2011-05-24 17:18:49 PDT
Committed r87235: <http://trac.webkit.org/changeset/87235>
Comment 8 Kent Tamura 2011-05-24 17:19:55 PDT
Comment on attachment 94587 [details]
Patch

Landed with a typo fix and const_cast removal.