Summary: | Use Element::shadowPseudoId() for text field decoration elements | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Kent Tamura <tkent> | ||||
Component: | DOM | Assignee: | Kent Tamura <tkent> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | dglazkov, morrita | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | All | ||||||
OS: | All | ||||||
Bug Depends on: | |||||||
Bug Blocks: | 61166 | ||||||
Attachments: |
|
Description
Kent Tamura
2011-05-24 02:32:11 PDT
Created attachment 94587 [details]
Patch
Comment on attachment 94587 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=94587&action=review > Source/WebCore/html/shadow/TextControlInnerElements.cpp:129 > + Node* host = const_cast<SearchFieldResultsButtonElement*>(this)->shadowAncestorNode(); Unfortunately const_cast<> is required. Too bad. Comment on attachment 94587 [details]
Patch
lovely.
Comment on attachment 94587 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=94587&action=review > Source/WebCore/ChangeLog:5 > + Use Element::shodowPseudoId() for text field decoration elements Misspelled changelog!! Sorry, didn't want this to land and forever be misspelled in the history of WebKit :) shodow!! Committed r87235: <http://trac.webkit.org/changeset/87235> Comment on attachment 94587 [details]
Patch
Landed with a typo fix and const_cast removal.
|