Bug 61327

Summary: editing/deleting/5032066 should be a dump-as-markup test
Product: WebKit Reporter: Annie Sullivan <sullivan>
Component: HTML EditingAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, rniwa
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 57148    
Attachments:
Description Flags
Patch
none
Patch none

Description Annie Sullivan 2011-05-23 17:33:01 PDT 
The results are pretty hard to read; it would be a lot easier to understand as markup.
Comment 1 Annie Sullivan 2011-05-23 17:35:59 PDT 
Created attachment 94524 [details]
Patch
Comment 2 Tony Chang 2011-05-24 10:37:41 PDT 
Comment on attachment 94524 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=94524&action=review

> LayoutTests/editing/deleting/5032066-expected.txt:7
> +|         "All the content in this editable region <#selection-caret>"

The linefeed character (Â) might vary on windows vs mac, so I'll try to watch the bots.
Comment 3 Tony Chang 2011-05-24 10:46:35 PDT 
Comment on attachment 94524 [details]
Patch

I guess Ryosuke prefers that we also improve the tests while we convert.  In that case, you could add <html> and <body> tags and maybe add some script that produces PASS/FAIL based on the output.  It also seems fine to improve tests in a separate change from converting since they're conceptually different changes.
Comment 4 Annie Sullivan 2011-05-24 15:14:47 PDT 
Created attachment 94701 [details]
Patch
Comment 5 Annie Sullivan 2011-05-24 15:18:21 PDT 
(In reply to comment #3)
> (From update of attachment 94524 [details])
> I guess Ryosuke prefers that we also improve the tests while we convert.  In that case, you could add <html> and <body> tags and maybe add some script that produces PASS/FAIL based on the output.  It also seems fine to improve tests in a separate change from converting since they're conceptually different changes.

I added the <html> and <body> tags. I wanted to keep the tests pretty close to what they started out as, so I skipped the PASS/FAIL for now.
Comment 6 WebKit Commit Bot 2011-05-24 21:15:03 PDT 
Comment on attachment 94701 [details]
Patch

Clearing flags on attachment: 94701

Committed r87264: <http://trac.webkit.org/changeset/87264>
Comment 7 WebKit Commit Bot 2011-05-24 21:15:09 PDT 
All reviewed patches have been landed.  Closing bug.