Summary: | Safari often freezes when clicking "Return free memory" in Caches dialog | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Michael Saboff <msaboff> | ||||
Component: | JavaScriptCore | Assignee: | Michael Saboff <msaboff> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | webkit.review.bot | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Description
Michael Saboff
2011-05-23 17:13:18 PDT
Created attachment 94523 [details]
Patch with 2 fixes and sanity check improvement
Attachment 94523 [details] did not pass style-queue:
Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/ChangeLog', u'Source..." exit_code: 1
Source/JavaScriptCore/wtf/FastMalloc.cpp:1360: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3]
Source/JavaScriptCore/wtf/FastMalloc.cpp:1360: min_pages is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4]
Source/JavaScriptCore/wtf/FastMalloc.cpp:1360: max_pages is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4]
Source/JavaScriptCore/wtf/FastMalloc.cpp:2122: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3]
Source/JavaScriptCore/wtf/FastMalloc.cpp:2123: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3]
Source/JavaScriptCore/wtf/FastMalloc.cpp:2132: Place brace on its own line for function definitions. [whitespace/braces] [4]
Source/JavaScriptCore/wtf/FastMalloc.cpp:2132: TCMalloc_PageHeap::CheckList is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4]
Source/JavaScriptCore/wtf/FastMalloc.cpp:2136: Place brace on its own line for function definitions. [whitespace/braces] [4]
Source/JavaScriptCore/wtf/FastMalloc.cpp:2136: TCMalloc_PageHeap::CheckList is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4]
Source/JavaScriptCore/wtf/FastMalloc.cpp:2136: min_pages is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4]
Source/JavaScriptCore/wtf/FastMalloc.cpp:2136: max_pages is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4]
Total errors found: 11 in 2 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Committed r87157: <http://trac.webkit.org/changeset/87157> |