Summary: | fix rel=prerender target types | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Gavin Peters <gavinp> | ||||||
Component: | New Bugs | Assignee: | Nobody <webkit-unassigned> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | abarth, ap, commit-queue, gavinp, tonyg, webkit.review.bot | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Attachments: |
|
Description
Gavin Peters
2011-05-23 12:23:11 PDT
Created attachment 94459 [details]
Patch
Comment on attachment 94459 [details]
Patch
I have learned a valuable lesson; always test the chrome side of a webkit patch that has chrome implication before uploading to WebKit.
Comment on attachment 94459 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=94459&action=review > Source/WebCore/ChangeLog:10 > + The original fix in https://bugs.webkit.org/show_bug.cgi?id=61079 > + didn't properly map the target type, and didn't carry the target > + types through to chromium properly. Fixed. Bad indent. > Source/WebCore/ChangeLog:12 > + No new tests. How come? Attachment 94459 [details] did not pass style-queue:
Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1
Source/WebKit/chromium/ChangeLog:8: Line contains tab character. [whitespace/tab] [5]
Source/WebKit/chromium/ChangeLog:9: Line contains tab character. [whitespace/tab] [5]
Source/WebKit/chromium/ChangeLog:10: Line contains tab character. [whitespace/tab] [5]
Source/WebCore/ChangeLog:8: Line contains tab character. [whitespace/tab] [5]
Source/WebCore/ChangeLog:9: Line contains tab character. [whitespace/tab] [5]
Source/WebCore/ChangeLog:10: Line contains tab character. [whitespace/tab] [5]
Total errors found: 6 in 4 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 94463 [details]
Patch
Comment on attachment 94463 [details]
Patch
tabsbegone, explanation about testing.
Comment on attachment 94463 [details] Patch Clearing flags on attachment: 94463 Committed r87106: <http://trac.webkit.org/changeset/87106> All reviewed patches have been landed. Closing bug. |