Bug 61278

Summary: Update expectations for shadow tests which are now passing.
Product: WebKit Reporter: scroggo
Component: New BugsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, jamesr, kbr, scroggo, steveblock, vangelis, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

scroggo
Reported 2011-05-23 06:18:05 PDT
Update expectations for shadow tests which are now passing.
Attachments
Patch (4.29 KB, patch)
2011-05-23 06:19 PDT, scroggo 		no flags
DetailsFormatted DiffDiff
Patch (4.90 KB, patch)
2011-05-23 07:01 PDT, scroggo 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
scroggo
Comment 1 2011-05-23 06:19:30 PDT
Created attachment 94414 [details] Patch
WebKit Review Bot
Comment 2 2011-05-23 06:23:02 PDT
Attachment 94414 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/plat..." exit_code: 1 LayoutTests/platform/chromium/test_expectations.txt:4079: Path does not exist. css3/images/optimize-contrast-canvas.html [test/expectations] [2] LayoutTests/platform/chromium/test_expectations.txt:4080: Path does not exist. css3/images/optimize-contrast-image.html [test/expectations] [2] Total errors found: 2 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style.
scroggo
Comment 3 2011-05-23 06:28:23 PDT
(In reply to comment #2) > Attachment 94414 [details] did not pass style-queue: > > Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/plat..." exit_code: 1 > > LayoutTests/platform/chromium/test_expectations.txt:4079: Path does not exist. css3/images/optimize-contrast-canvas.html [test/expectations] [2] > LayoutTests/platform/chromium/test_expectations.txt:4080: Path does not exist. css3/images/optimize-contrast-image.html [test/expectations] [2] > Total errors found: 2 in 2 files > > > If any of these errors are false positives, please file a bug against check-webkit-style. How do I solve this problem? I did not add those lines to test_expectations, nor did I remove the tests.
scroggo
Comment 4 2011-05-23 07:01:33 PDT
Created attachment 94420 [details] Patch
James Robinson
Comment 5 2011-05-23 10:55:19 PDT
Comment on attachment 94420 [details] Patch Awesome!
WebKit Commit Bot
Comment 6 2011-05-24 03:04:53 PDT
Comment on attachment 94420 [details] Patch Clearing flags on attachment: 94420 Committed r87142: <http://trac.webkit.org/changeset/87142>
WebKit Commit Bot
Comment 7 2011-05-24 03:04:58 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.